Stop preloading scripts that have invalid type/language attributes

third_party/WebKit/Source/core/html/parser/HTMLPreloadScanner.cpp

 /*
  * Copyright (C) 2008 Apple Inc. All Rights Reserved.
  * Copyright (C) 2009 Torch Mobile, Inc. http://www.torchmobile.com/
  * Copyright (C) 2010 Google Inc. All Rights Reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  * 1. Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
@@ skipping 235 matching lines @@
         referrerPolicy, resourceWidth, clientHintsPreferences, requestType);
     if (!request)
       return nullptr;
 
     request->setCrossOrigin(m_crossOrigin);
     request->setNonce(m_nonce);
     request->setCharset(charset());
     request->setDefer(m_defer);
     request->setIntegrityMetadata(m_integrityMetadata);
 
-    // TODO(csharrison): Once this is deprecated, just abort the request here.
     if (match(m_tagImpl, scriptTag) &&

[Charlie Harrison, 2016/11/03 21:00:40]

Can this check be moved to shouldPreload()?

         !ScriptLoader::isValidScriptTypeAndLanguage(
             m_typeAttributeValue, m_languageAttributeValue,
             ScriptLoader::AllowLegacyTypeInTypeAttribute))
-      request->setScriptHasInvalidTypeOrLanguage();
+      return nullptr;
     return request;
   }
 
  private:
   template <typename NameType>
   void processScriptAttribute(const NameType& attributeName,
                               const String& attributeValue) {
     // FIXME - Don't set crossorigin multiple times.
     if (match(attributeName, srcAttr))
       setUrlToLoad(attributeValue, DisallowURLReplacement);
@@ skipping 623 matching lines @@
   defaultViewportMinWidth = document->viewportDefaultMinWidth();
   viewportMetaZeroValuesQuirk =
       document->settings() &&
       document->settings()->viewportMetaZeroValuesQuirk();
   viewportMetaEnabled =
       document->settings() && document->settings()->viewportMetaEnabled();
   referrerPolicy = document->getReferrerPolicy();
 }
 
 }  // namespace blink