Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(453)

Issue 2473003004: [compiler] Generalize context load/store operations in code-stub-assembler. (Closed)

Created:
4 years, 1 month ago by neis
Modified:
4 years, 1 month ago
CC:
v8-reviews_googlegroups.com, rmcilroy
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[compiler] Generalize context load/store operations in code-stub-assembler. The existing Load/StoreContextElement operations take the index as an int. This CL adds versions that take the index as a Node. These already existed in the interpreter-assembler, from which they are now removed. R=mstarzinger@chromium.org, rmcilroy@chromium.org BUG= Committed: https://crrev.com/08da5c98cfdac4a690bcaf74781f458d89d910a8 Cr-Commit-Position: refs/heads/master@{#40810}

Patch Set 1 #

Patch Set 2 : Remove tests. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -62 lines) Patch
M src/code-stub-assembler.h View 1 chunk +5 lines, -0 lines 0 comments Download
M src/code-stub-assembler.cc View 2 chunks +15 lines, -0 lines 0 comments Download
M src/interpreter/interpreter.cc View 5 chunks +6 lines, -6 lines 0 comments Download
M src/interpreter/interpreter-assembler.h View 1 chunk +0 lines, -8 lines 0 comments Download
M src/interpreter/interpreter-assembler.cc View 1 chunk +0 lines, -15 lines 0 comments Download
M test/unittests/interpreter/interpreter-assembler-unittest.cc View 1 1 chunk +0 lines, -33 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 9 (3 generated)
neis
4 years, 1 month ago (2016-11-04 13:41:24 UTC) #1
neis
Not sure what to do with the unittests. They don't belong there anymore but I ...
4 years, 1 month ago (2016-11-04 13:42:11 UTC) #2
rmcilroy
> Not sure what to do with the unittests. They don't belong there anymore but ...
4 years, 1 month ago (2016-11-04 14:25:52 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2473003004/20001
4 years, 1 month ago (2016-11-07 17:15:06 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 1 month ago (2016-11-07 17:42:20 UTC) #7
commit-bot: I haz the power
4 years, 1 month ago (2016-11-17 22:25:02 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/08da5c98cfdac4a690bcaf74781f458d89d910a8
Cr-Commit-Position: refs/heads/master@{#40810}

Powered by Google App Engine
This is Rietveld 408576698