Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(319)

Issue 2470253003: [ignition] Reuse code-stub-assembler's context load operations. (Closed)

Created:
4 years, 1 month ago by neis
Modified:
4 years, 1 month ago
CC:
v8-reviews_googlegroups.com, rmcilroy
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[ignition] Reuse code-stub-assembler's context load operations. - Remove (one version of) InterpreterAssembler::LoadContextSlot in favor of the identical CodeStubAssembler::LoadContextElement. - Use CodeStubAssembler::LoadNativeContext instead of doing the load manually. R=rmcilroy@chromium.org BUG= Committed: https://crrev.com/bcd9aefb595bbe5da2107d9c64c6872393ca3a5a Cr-Commit-Position: refs/heads/master@{#40766}

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -14 lines) Patch
M src/interpreter/interpreter.cc View 2 chunks +4 lines, -5 lines 0 comments Download
M src/interpreter/interpreter-assembler.h View 1 chunk +0 lines, -1 line 2 comments Download
M src/interpreter/interpreter-assembler.cc View 3 chunks +3 lines, -8 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 12 (5 generated)
neis
4 years, 1 month ago (2016-11-03 14:06:41 UTC) #1
neis
+mstarzinger since ross is ooo
4 years, 1 month ago (2016-11-04 10:56:19 UTC) #4
rmcilroy
LGTM with an optional suggestion. https://codereview.chromium.org/2470253003/diff/1/src/interpreter/interpreter-assembler.h File src/interpreter/interpreter-assembler.h (right): https://codereview.chromium.org/2470253003/diff/1/src/interpreter/interpreter-assembler.h#newcode102 src/interpreter/interpreter-assembler.h:102: compiler::Node* value); Optional - ...
4 years, 1 month ago (2016-11-04 11:29:56 UTC) #5
neis
https://codereview.chromium.org/2470253003/diff/1/src/interpreter/interpreter-assembler.h File src/interpreter/interpreter-assembler.h (right): https://codereview.chromium.org/2470253003/diff/1/src/interpreter/interpreter-assembler.h#newcode102 src/interpreter/interpreter-assembler.h:102: compiler::Node* value); On 2016/11/04 11:29:56, rmcilroy (OOO - slow) ...
4 years, 1 month ago (2016-11-04 13:00:33 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2470253003/1
4 years, 1 month ago (2016-11-04 13:00:47 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-04 13:25:29 UTC) #10
commit-bot: I haz the power
4 years, 1 month ago (2016-11-17 22:22:51 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/bcd9aefb595bbe5da2107d9c64c6872393ca3a5a
Cr-Commit-Position: refs/heads/master@{#40766}

Powered by Google App Engine
This is Rietveld 408576698