Fixs bug in notifying clients about hierarchy changes

Fixs bug in notifying clients about hierarchy changes

Here's the specific case, and this only applies to the window manager:
. Client other than WM creates window A.
. Client adds A to the root
At this point the WM knows about A via an OnWindowHierarchyChanged().
. Client removes A.
. Client creates new window B.
The WM doesn't know about B.
. Client adds A to B.
The WM still doesn't know about B, further the WM think's A's parent is null.
. Client adds B to the root.
This triggers an OnWindowHierarchyChanged() for the window manager
with B and a parent of the root. Before the fix
OnWindowHierarchyChanged() didn't contain A, so that the WM thought A
still had no parent and would get confused later on if a
OnWindowHierarchyChanged() was sent for A with a different parent.

The fix is to make the last OnWindowHierarchyChanged() include A in
the data parameter.

This was uncovered in getting views to work with aura-mus. I've
included test coverage of the case.

BUG=660994
TEST=covered by test
R=ben@chromium.org

Committed: https://crrev.com/e093db69fd792577d46415a736fe8245b544940e
Cr-Commit-Position: refs/heads/master@{#430327}

[sky, 2016-11-04 23:03:36]

Description was changed from

==========
Fixs bug in notifying clients about hierarchy changes

Here's the specific case, and this only applies to the window manager:
. Client other than WM creates window A.
. Client adds A to the root
At this point the WM knows about A via an OnWindowHierarchyChanged().
. Client removes A.
. Client creates new window B.
The WM doesn't know about B.
. Client adds A to B.
The WM still doesn't know about B, further the WM think's A's parent is null.
. Client adds B to the root.
This triggers an OnWindowHierarchyChanged() for the window manager
with B and a parent of the root. Before the fix
OnWindowHierarchyChanged() didn't contain A, so that the WM thought A
still had no parent and would get confused later on if a
OnWindowHierarchyChanged() was sent for A with a different parent.

The fix is to make the last OnWindowHierarchyChanged() include A in
the data parameter.

This was uncovered in getting views to work with aura-mus. I've
included test coverage of the case.

BUG=660994
TEST=covered by test
R=ben@chromium.org
==========

to

==========
Fixs bug in notifying clients about hierarchy changes

Here's the specific case, and this only applies to the window manager:
. Client other than WM creates window A.
. Client adds A to the root
At this point the WM knows about A via an OnWindowHierarchyChanged().
. Client removes A.
. Client creates new window B.
The WM doesn't know about B.
. Client adds A to B.
The WM still doesn't know about B, further the WM think's A's parent is null.
. Client adds B to the root.
This triggers an OnWindowHierarchyChanged() for the window manager
with B and a parent of the root. Before the fix
OnWindowHierarchyChanged() didn't contain A, so that the WM thought A
still had no parent and would get confused later on if a
OnWindowHierarchyChanged() was sent for A with a different parent.

The fix is to make the last OnWindowHierarchyChanged() include A in
the data parameter.

This was uncovered in getting views to work with aura-mus. I've
included test coverage of the case.

BUG=660994
TEST=covered by test
R=ben@chromium.org
==========

[sky, 2016-11-04 23:03:36]

sky@chromium.org changed reviewers:
+ tsepez@chromium.org

[sky, 2016-11-04 23:03:44]

The CQ bit was checked by sky@chromium.org to run a CQ dry run

[sky, 2016-11-04 23:04:00]

tsepez: mojom (clarifies new behavior)
ben: the rest

[commit-bot: I haz the power, 2016-11-04 23:04:57]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Ben Goodger (Google), 2016-11-05 00:35:08]

lgtm

[commit-bot: I haz the power, 2016-11-05 01:09:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-05 01:09:22]

Dry run: This issue passed the CQ dry run.

[Tom Sepez, 2016-11-07 17:55:11]

RS LGTM on writing comments.

[sky, 2016-11-07 17:56:28]

The CQ bit was checked by sky@chromium.org

[commit-bot: I haz the power, 2016-11-07 17:57:05]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-07 18:52:17]

Description was changed from

==========
Fixs bug in notifying clients about hierarchy changes

Here's the specific case, and this only applies to the window manager:
. Client other than WM creates window A.
. Client adds A to the root
At this point the WM knows about A via an OnWindowHierarchyChanged().
. Client removes A.
. Client creates new window B.
The WM doesn't know about B.
. Client adds A to B.
The WM still doesn't know about B, further the WM think's A's parent is null.
. Client adds B to the root.
This triggers an OnWindowHierarchyChanged() for the window manager
with B and a parent of the root. Before the fix
OnWindowHierarchyChanged() didn't contain A, so that the WM thought A
still had no parent and would get confused later on if a
OnWindowHierarchyChanged() was sent for A with a different parent.

The fix is to make the last OnWindowHierarchyChanged() include A in
the data parameter.

This was uncovered in getting views to work with aura-mus. I've
included test coverage of the case.

BUG=660994
TEST=covered by test
R=ben@chromium.org
==========

to

==========
Fixs bug in notifying clients about hierarchy changes

Here's the specific case, and this only applies to the window manager:
. Client other than WM creates window A.
. Client adds A to the root
At this point the WM knows about A via an OnWindowHierarchyChanged().
. Client removes A.
. Client creates new window B.
The WM doesn't know about B.
. Client adds A to B.
The WM still doesn't know about B, further the WM think's A's parent is null.
. Client adds B to the root.
This triggers an OnWindowHierarchyChanged() for the window manager
with B and a parent of the root. Before the fix
OnWindowHierarchyChanged() didn't contain A, so that the WM thought A
still had no parent and would get confused later on if a
OnWindowHierarchyChanged() was sent for A with a different parent.

The fix is to make the last OnWindowHierarchyChanged() include A in
the data parameter.

This was uncovered in getting views to work with aura-mus. I've
included test coverage of the case.

BUG=660994
TEST=covered by test
R=ben@chromium.org
==========

[commit-bot: I haz the power, 2016-11-07 18:52:24]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-11-07 18:56:49]

Description was changed from

==========
Fixs bug in notifying clients about hierarchy changes

Here's the specific case, and this only applies to the window manager:
. Client other than WM creates window A.
. Client adds A to the root
At this point the WM knows about A via an OnWindowHierarchyChanged().
. Client removes A.
. Client creates new window B.
The WM doesn't know about B.
. Client adds A to B.
The WM still doesn't know about B, further the WM think's A's parent is null.
. Client adds B to the root.
This triggers an OnWindowHierarchyChanged() for the window manager
with B and a parent of the root. Before the fix
OnWindowHierarchyChanged() didn't contain A, so that the WM thought A
still had no parent and would get confused later on if a
OnWindowHierarchyChanged() was sent for A with a different parent.

The fix is to make the last OnWindowHierarchyChanged() include A in
the data parameter.

This was uncovered in getting views to work with aura-mus. I've
included test coverage of the case.

BUG=660994
TEST=covered by test
R=ben@chromium.org
==========

to

==========
Fixs bug in notifying clients about hierarchy changes

Here's the specific case, and this only applies to the window manager:
. Client other than WM creates window A.
. Client adds A to the root
At this point the WM knows about A via an OnWindowHierarchyChanged().
. Client removes A.
. Client creates new window B.
The WM doesn't know about B.
. Client adds A to B.
The WM still doesn't know about B, further the WM think's A's parent is null.
. Client adds B to the root.
This triggers an OnWindowHierarchyChanged() for the window manager
with B and a parent of the root. Before the fix
OnWindowHierarchyChanged() didn't contain A, so that the WM thought A
still had no parent and would get confused later on if a
OnWindowHierarchyChanged() was sent for A with a different parent.

The fix is to make the last OnWindowHierarchyChanged() include A in
the data parameter.

This was uncovered in getting views to work with aura-mus. I've
included test coverage of the case.

BUG=660994
TEST=covered by test
R=ben@chromium.org

Committed: https://crrev.com/e093db69fd792577d46415a736fe8245b544940e
Cr-Commit-Position: refs/heads/master@{#430327}
==========

[commit-bot: I haz the power, 2016-11-07 18:56:50]

Patchset 2 (id:??) landed as
https://crrev.com/e093db69fd792577d46415a736fe8245b544940e
Cr-Commit-Position: refs/heads/master@{#430327}