Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(246)

Issue 2472963002: Suborigins should not crash fragment navigations. (Closed)

Created:
4 years, 1 month ago by Mike West
Modified:
4 years, 1 month ago
CC:
blink-reviews, chromium-reviews, creis+watch_chromium.org, darin-cc_chromium.org, jam, mlamouri+watch-content_chromium.org, nasko+codewatch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Suborigins should not crash fragment navigations. We should be checking for physical origin matches when committing URLs, as the URL we commit doesn't include the suborigin. BUG=660683 R=jochen@chromium.org Committed: https://crrev.com/25ec43232e79ebfe0c4fdd2e301d957268c66e26 Cr-Commit-Position: refs/heads/master@{#429563}

Patch Set 1 #

Patch Set 2 : history.pushState #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -1 line) Patch
M content/renderer/render_frame_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
A third_party/WebKit/LayoutTests/http/tests/security/suborigins/suborigin-in-page-navigation.php View 1 1 chunk +38 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (7 generated)
Mike West
jochen@: WDYT? Hopefully you weren't also looking at this.
4 years, 1 month ago (2016-11-03 10:31:48 UTC) #3
jochen (gone - plz use gerrit)
lgtm
4 years, 1 month ago (2016-11-03 10:36:03 UTC) #4
Mike West
Added a test for `pushState`.
4 years, 1 month ago (2016-11-03 11:51:24 UTC) #7
jochen (gone - plz use gerrit)
cool, thx still lgtm
4 years, 1 month ago (2016-11-03 11:52:05 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2472963002/20001
4 years, 1 month ago (2016-11-03 12:21:19 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 1 month ago (2016-11-03 13:48:13 UTC) #12
commit-bot: I haz the power
4 years, 1 month ago (2016-11-03 13:50:27 UTC) #14
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/25ec43232e79ebfe0c4fdd2e301d957268c66e26
Cr-Commit-Position: refs/heads/master@{#429563}

Powered by Google App Engine
This is Rietveld 408576698