Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(730)

Unified Diff: content/renderer/render_frame_impl.cc

Issue 2472963002: Suborigins should not crash fragment navigations. (Closed)
Patch Set: history.pushState Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/WebKit/LayoutTests/http/tests/security/suborigins/suborigin-in-page-navigation.php » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/renderer/render_frame_impl.cc
diff --git a/content/renderer/render_frame_impl.cc b/content/renderer/render_frame_impl.cc
index 10f5c4c605ff7c6b60398cfe2e7c902799fbb04e..1c1a904259ad877e9f551a283f9a1c8f2e921b9b 100644
--- a/content/renderer/render_frame_impl.cc
+++ b/content/renderer/render_frame_impl.cc
@@ -4969,7 +4969,7 @@ void RenderFrameImpl::SendDidCommitProvisionalLoad(
base::debug::SetCrashKeyValue(
"origin_mismatch_same_page",
base::IntToString(params.was_within_same_page));
- CHECK(params.origin.IsSameOriginWith(url::Origin(params.url)))
+ CHECK(params.origin.IsSamePhysicalOriginWith(url::Origin(params.url)))
<< " url:" << params.url << " origin:" << params.origin;
}
}
« no previous file with comments | « no previous file | third_party/WebKit/LayoutTests/http/tests/security/suborigins/suborigin-in-page-navigation.php » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698