Revert 225398 "Fix a threading bug in the brlapi basec braille c..."

Revert 225398 "Fix a threading bug in the brlapi basec braille c..."

Breaks Linux Chromium OS ASAN compile.

> Fix a threading bug in the brlapi basec braille controller
> 
> This CL enables brlapi support by default in builds for chromeos (it's already enabled by default in chromeos itself, so that part is a noop). This revealed a threading bug in the implementation which is also fixed my moving a file_path_watcher from the IO thread to the FILE threadd.
> 
> BUG=178559
> 
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=225008
> 
> Review URL: https://codereview.chromium.org/24325002

TBR=plundblad@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=225411

[calamity, 2013-09-26 09:17:31]

Committed patchset #1 manually as r225411.

[hashimoto, 2013-09-26 09:53:09]

Seems compile failing on ASAN bots and "Google Chrome ChromeOS" builder.
-
http://build.chromium.org/p/chromium.memory/builders/Linux%20Chromium%20OS%20...
-
http://build.chromium.org/p/chromium.chrome/builders/Google%20Chrome%20Chrome...

I think you should run install_build_deps.sh on these failing bots to before
landing this patch again.
Also, it'll be nice if you could make a PSA on chromium-dev to warn Chromium OS
developers to run install-build-deps.sh again on their machines to avoid being
hit by the same compile error locally.
Thanks,

[plundblad, 2013-09-26 17:03:28]

Hi,

Sorry for breaking the build a second time in the same way:-(
According to the infrastructure team, the required dependency had
been installed on all the bots.  I am bugging them separately again.

//Peter


hashimoto@chromium.org writes:
> Seems compile failing on ASAN bots and "Google Chrome ChromeOS" builder.
> -
>
http://build.chromium.org/p/chromium.memory/builders/Linux%20Chromium%20OS%20...
> -
>
http://build.chromium.org/p/chromium.chrome/builders/Google%20Chrome%20Chrome...
> 
> I think you should run install_build_deps.sh on these failing bots to before
> landing this patch again.
> Also, it'll be nice if you could make a PSA on chromium-dev to warn  
> Chromium OS
> developers to run install-build-deps.sh again on their machines to avoid  
> being
> hit by the same compile error locally.
> Thanks,
> 
> https://codereview.chromium.org/24729002/

-- 

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.