Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(146)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 24325002: Fix threading bug in the brlapi braille controller (Closed)

Created:
7 years, 3 months ago by Peter Lundblad
Modified:
7 years, 2 months ago
Reviewers:
dmazzoni, David Tseng
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@lkgr
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Move file_path_watcher to FILE thread, bug discovered by browser test on trybot #

Patch Set 3 : OVERRIDE #

Patch Set 4 : #

Patch Set 5 : #

Patch Set 6 : #

Patch Set 7 : Revert the revert of this CL. #

Patch Set 8 : Remove the part that enables brlapi by default. #

Patch Set 9 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -14 lines) Patch
M chrome/browser/extensions/api/braille_display_private/braille_controller_brlapi.h View 1 3 chunks +7 lines, -3 lines 0 comments Download
M chrome/browser/extensions/api/braille_display_private/braille_controller_brlapi.cc View 1 2 chunks +27 lines, -9 lines 0 comments Download
M chrome/browser/extensions/api/braille_display_private/braille_display_private_apitest.cc View 1 2 3 4 5 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 17 (0 generated)
Peter Lundblad
Thanks, trybots! ;)
7 years, 3 months ago (2013-09-20 21:19:39 UTC) #1
dmazzoni
lgtm
7 years, 3 months ago (2013-09-23 06:18:00 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/plundblad@chromium.org/24325002/22001
7 years, 3 months ago (2013-09-23 15:19:23 UTC) #3
commit-bot: I haz the power
Retried try job too often on linux_chromeos_clang for step(s) compile http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_chromeos_clang&number=48761
7 years, 3 months ago (2013-09-23 16:11:19 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/plundblad@chromium.org/24325002/83001
7 years, 3 months ago (2013-09-23 21:12:24 UTC) #5
commit-bot: I haz the power
Retried try job too often on linux_aura for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_aura&number=79676
7 years, 3 months ago (2013-09-24 01:33:47 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/plundblad@chromium.org/24325002/83001
7 years, 3 months ago (2013-09-24 06:18:02 UTC) #7
commit-bot: I haz the power
Change committed as 225008
7 years, 3 months ago (2013-09-24 16:44:18 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/plundblad@chromium.org/24325002/109001
7 years, 2 months ago (2013-09-26 01:13:10 UTC) #9
commit-bot: I haz the power
Change committed as 225398
7 years, 2 months ago (2013-09-26 08:37:39 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/plundblad@chromium.org/24325002/167001
7 years, 2 months ago (2013-09-27 18:11:27 UTC) #11
commit-bot: I haz the power
Retried try job too often on linux_chromeos for step(s) unit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_chromeos&number=159685
7 years, 2 months ago (2013-09-27 20:14:16 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/plundblad@chromium.org/24325002/167001
7 years, 2 months ago (2013-09-27 20:54:07 UTC) #13
commit-bot: I haz the power
Retried try job too often on linux_chromeos for step(s) browser_tests, unit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_chromeos&number=159784
7 years, 2 months ago (2013-09-27 22:39:09 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/plundblad@chromium.org/24325002/210001
7 years, 2 months ago (2013-09-30 15:07:43 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/plundblad@chromium.org/24325002/210001
7 years, 2 months ago (2013-09-30 15:10:05 UTC) #16
commit-bot: I haz the power
7 years, 2 months ago (2013-09-30 21:46:55 UTC) #17
Message was sent while issue was closed. 
Change committed as 226051

Powered by Google App Engine
This is Rietveld 408576698