Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(182)

Issue 2472823002: DO NOT LAND - Hacked MSE mp3 support, assuming addSourceBuffer /mp4; codecs="mp4a.40.2" (Closed)

Created:
4 years, 1 month ago by wolenetz
Modified:
4 years, 1 month ago
Reviewers:
CC:
chromium-reviews, posciak+watch_chromium.org, feature-media-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DO NOT LAND - Hacked MSE mp3 support, assuming addSourceBuffer /mp4; codecs="mp4a.40.2" This CL is NOT for production landing. It just demonstrates that decode of mp3 in mp4 via MSE *can* work in Chrome. It disables a bunch of checks and assumes mp3 when the mp4 stream parser finds some other audio object type. Seems to show pipeline can work with mp3 in mp4 in MSE - used hacked version of https://chrisguttandin.github.io/mse-tests/ (just the MP3 inside of a MP4 container, with addSourceBuffer mimetype codec string adjusted to non-MP3 mp4a.40.2 just to get past the existing checks. Production version of a real fix will need, at least, StreamParserFactory allowances for real mp3 codec strings, correct adjustments to mp4 stream parser, and tests. BUG=661749

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -6 lines) Patch
M media/filters/source_buffer_state.cc View 1 chunk +8 lines, -3 lines 0 comments Download
M media/formats/mp4/mp4_stream_parser.cc View 3 chunks +10 lines, -3 lines 0 comments Download

Messages

Total messages: 1 (1 generated)
wolenetz
4 years, 1 month ago (2016-11-02 21:58:19 UTC) #1
Description was changed from

==========
DO NOT LAND - Hacked MSE mp3 support, assuming addSourceBuffer /mp4;
codecs="mp4a.40.2"

This CL is NOT for production landing. It just demonstrates that decode
of mp3 in mp4 via MSE *can* work in Chrome. It disables a bunch of
checks and assumes mp3 when the mp4 stream parser finds some other audio
object type.

Seems to show pipeline can work with mp3 in mp4 in MSE - used hacked
version of https://chrisguttandin.github.io/mse-tests/ (just the MP3
inside of a MP4 container, with addSourceBuffer mimetype codec string
adjusted to non-MP3 mp4a.40.2 just to get past the existing checks.

Production version of a real fix will need, at least,
StreamParserFactory allowances for real mp3 codec strings, correct
adjustments to mp4 stream parser, and tests.

BUG=661749
==========

to

==========
DO NOT LAND - Hacked MSE mp3 support, assuming addSourceBuffer /mp4;
codecs="mp4a.40.2"

This CL is NOT for production landing. It just demonstrates that decode
of mp3 in mp4 via MSE *can* work in Chrome. It disables a bunch of
checks and assumes mp3 when the mp4 stream parser finds some other audio
object type.

Seems to show pipeline can work with mp3 in mp4 in MSE - used hacked
version of https://chrisguttandin.github.io/mse-tests/ (just the MP3
inside of a MP4 container, with addSourceBuffer mimetype codec string
adjusted to non-MP3 mp4a.40.2 just to get past the existing checks.

Production version of a real fix will need, at least,
StreamParserFactory allowances for real mp3 codec strings, correct
adjustments to mp4 stream parser, and tests.

BUG=661749
==========

Powered by Google App Engine
This is Rietveld 408576698