Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(542)

Unified Diff: media/formats/mp4/mp4_stream_parser.cc

Issue 2472823002: DO NOT LAND - Hacked MSE mp3 support, assuming addSourceBuffer /mp4; codecs="mp4a.40.2" (Closed)
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « media/filters/source_buffer_state.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: media/formats/mp4/mp4_stream_parser.cc
diff --git a/media/formats/mp4/mp4_stream_parser.cc b/media/formats/mp4/mp4_stream_parser.cc
index 8e8ec08b3898ab20bd27f4fc79110cbc44d1cd5f..66e04b54062ebca3b50477271345584f763ed317 100644
--- a/media/formats/mp4/mp4_stream_parser.cc
+++ b/media/formats/mp4/mp4_stream_parser.cc
@@ -245,7 +245,8 @@ bool MP4StreamParser::ParseMoov(BoxReader* reader) {
MEDIA_LOG(ERROR, media_log_) << "Unsupported audio format 0x"
<< std::hex << entry.format
<< " in stsd box.";
- return false;
+ // BIG TODO remove comment
+ // return false;
}
uint8_t audio_type = entry.esds.object_type;
@@ -263,7 +264,8 @@ bool MP4StreamParser::ParseMoov(BoxReader* reader) {
<< "audio object type 0x" << std::hex
<< static_cast<int>(audio_type)
<< " does not match what is specified in the mimetype.";
- return false;
+ // BIG TODO remove comment
+ // return false;
}
AudioCodec codec = kUnknownAudioCodec;
@@ -293,7 +295,12 @@ bool MP4StreamParser::ParseMoov(BoxReader* reader) {
MEDIA_LOG(ERROR, media_log_) << "Unsupported audio object type 0x"
<< std::hex << static_cast<int>(audio_type)
<< " in esds.";
- return false;
+ // BIG TODO undo this...
+ codec = kCodecMP3;
+ channel_layout = GuessChannelLayout(entry.channelcount);
+ sample_per_second = entry.samplerate;
+
+ // return false;
}
SampleFormat sample_format;
« no previous file with comments | « media/filters/source_buffer_state.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698