Move fromJSONString to V8Binding

Move fromJSONString to V8Binding

Move fromJSONString to V8Binding and start using it
in a few more places.

Also remove JSONValuesForV8.* since that was the only
function it contained.

Committed: https://crrev.com/36757cf38870dd6fa9f4e4110edf077a7a4ac8d8
Cr-Commit-Position: refs/heads/master@{#429762}

[rwlbuis, 2016-11-03 13:23:18]

Description was changed from

==========
fromJSONString WIP

BUG=
==========

to

==========
Move fromJSONString to V8Binding
==========

[rwlbuis, 2016-11-03 13:24:27]

Description was changed from

==========
Move fromJSONString to V8Binding
==========

to

==========
Move fromJSONString to V8Binding

Move fromJSONString to V8Binding and start using it
in a few more places.

Also remove JSONValuesForV8.* since that was the only
function it contained.
==========

[rwlbuis, 2016-11-03 13:53:52]

rob.buis@samsung.com changed reviewers:
+ haraken@chromium.org

[rwlbuis, 2016-11-03 13:53:52]

PTAL.

I tried to use it in a few more places like fetch/Body.cpp but I run into
crashes with lifetime of the Exception object (probably because of TryCatch
being removed). These crashes do not seem to happen when I pass ExceptionStates,
but in the case of Body.cpp I don't really want to create one if it can be
avoided...

[haraken, 2016-11-03 14:01:36]

https://codereview.chromium.org/2472753003/diff/20001/third_party/WebKit/Sour...
File
third_party/WebKit/Source/bindings/core/v8/custom/V8XMLHttpRequestCustom.cpp
(right):

https://codereview.chromium.org/2472753003/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/bindings/core/v8/custom/V8XMLHttpRequestCustom.cpp:87:
TrackExceptionState exceptionState;

Use a normal ExceptionState instead of TrackExceptionState. See line 55.

[rwlbuis, 2016-11-03 14:12:59]

https://codereview.chromium.org/2472753003/diff/20001/third_party/WebKit/Sour...
File
third_party/WebKit/Source/bindings/core/v8/custom/V8XMLHttpRequestCustom.cpp
(right):

https://codereview.chromium.org/2472753003/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/bindings/core/v8/custom/V8XMLHttpRequestCustom.cpp:87:
TrackExceptionState exceptionState;
On 2016/11/03 14:01:35, haraken wrote:
> 
> Use a normal ExceptionState instead of TrackExceptionState. See line 55.

Acknowledged.

[haraken, 2016-11-03 14:26:38]

LGTM

https://codereview.chromium.org/2472753003/diff/40001/third_party/WebKit/Sour...
File
third_party/WebKit/Source/bindings/core/v8/custom/V8XMLHttpRequestCustom.cpp
(right):

https://codereview.chromium.org/2472753003/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/bindings/core/v8/custom/V8XMLHttpRequestCustom.cpp:89:
info.Holder(), info.GetIsolate());

Would you put this at line 69? I'd like to make the custom binding look like the
auto-generated code as much as possible.

[rwlbuis, 2016-11-03 14:37:58]

On 2016/11/03 14:26:38, haraken wrote:
>
https://codereview.chromium.org/2472753003/diff/40001/third_party/WebKit/Sour...
>
third_party/WebKit/Source/bindings/core/v8/custom/V8XMLHttpRequestCustom.cpp:89:
> info.Holder(), info.GetIsolate());
> 
> Would you put this at line 69? I'd like to make the custom binding look like
the
> auto-generated code as much as possible.

Sure, will do.

[rwlbuis, 2016-11-03 14:40:07]

The CQ bit was checked by rob.buis@samsung.com

[rwlbuis, 2016-11-03 14:40:08]

The patchset sent to the CQ was uploaded after l-g-t-m from haraken@chromium.org
Link to the patchset: https://codereview.chromium.org/2472753003/#ps60001
(title: "Patch for landing")

[commit-bot: I haz the power, 2016-11-03 14:40:36]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-03 16:48:38]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-03 16:48:39]

Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[rwlbuis, 2016-11-03 19:21:54]

The CQ bit was checked by rob.buis@samsung.com

[rwlbuis, 2016-11-03 19:21:54]

The patchset sent to the CQ was uploaded after l-g-t-m from haraken@chromium.org
Link to the patchset: https://codereview.chromium.org/2472753003/#ps80001
(title: "Reallt swallow exception")

[commit-bot: I haz the power, 2016-11-03 19:23:22]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-03 22:15:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-03 22:15:11]

Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[rwlbuis, 2016-11-03 22:32:43]

The CQ bit was checked by rob.buis@samsung.com

[commit-bot: I haz the power, 2016-11-03 22:33:46]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-04 01:45:59]

Description was changed from

==========
Move fromJSONString to V8Binding

Move fromJSONString to V8Binding and start using it
in a few more places.

Also remove JSONValuesForV8.* since that was the only
function it contained.
==========

to

==========
Move fromJSONString to V8Binding

Move fromJSONString to V8Binding and start using it
in a few more places.

Also remove JSONValuesForV8.* since that was the only
function it contained.
==========

[commit-bot: I haz the power, 2016-11-04 01:46:00]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2016-11-04 01:47:46]

Description was changed from

==========
Move fromJSONString to V8Binding

Move fromJSONString to V8Binding and start using it
in a few more places.

Also remove JSONValuesForV8.* since that was the only
function it contained.
==========

to

==========
Move fromJSONString to V8Binding

Move fromJSONString to V8Binding and start using it
in a few more places.

Also remove JSONValuesForV8.* since that was the only
function it contained.

Committed: https://crrev.com/36757cf38870dd6fa9f4e4110edf077a7a4ac8d8
Cr-Commit-Position: refs/heads/master@{#429762}
==========

[commit-bot: I haz the power, 2016-11-04 01:47:47]

Patchset 5 (id:??) landed as
https://crrev.com/36757cf38870dd6fa9f4e4110edf077a7a4ac8d8
Cr-Commit-Position: refs/heads/master@{#429762}