Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(791)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: third_party/WebKit/Source/modules/payments/PaymentResponse.cpp

Issue 2472753003: Move fromJSONString to V8Binding (Closed)
Patch Set: Really swallow exception Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/modules/payments/PaymentRequestTest.cpp ('k') | third_party/WebKit/Source/modules/push_messaging/PushMessageData.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/modules/payments/PaymentResponse.cpp
diff --git a/third_party/WebKit/Source/modules/payments/PaymentResponse.cpp b/third_party/WebKit/Source/modules/payments/PaymentResponse.cpp
index 126303e00cba3d3fc706f10d429d3b204321061a..53762afa52fc495ed135d09503ac199486d20a0a 100644
--- a/third_party/WebKit/Source/modules/payments/PaymentResponse.cpp
+++ b/third_party/WebKit/Source/modules/payments/PaymentResponse.cpp
@@ -5,7 +5,6 @@
#include "modules/payments/PaymentResponse.h"
#include "bindings/core/v8/ExceptionStatePlaceholder.h"
-#include "bindings/core/v8/JSONValuesForV8.h"
#include "bindings/core/v8/V8ObjectBuilder.h"
#include "modules/payments/PaymentAddress.h"
#include "modules/payments/PaymentCompleter.h"
@@ -63,8 +62,8 @@ ScriptValue PaymentResponse::toJSONForBinding(ScriptState* scriptState) const {
ScriptValue PaymentResponse::details(ScriptState* scriptState,
ExceptionState& exceptionState) const {
return ScriptValue(
- scriptState,
- fromJSONString(scriptState, m_stringifiedDetails, exceptionState));
+ scriptState, fromJSONString(scriptState->isolate(), m_stringifiedDetails,
+ exceptionState));
}
ScriptPromise PaymentResponse::complete(ScriptState* scriptState,
« no previous file with comments | « third_party/WebKit/Source/modules/payments/PaymentRequestTest.cpp ('k') | third_party/WebKit/Source/modules/push_messaging/PushMessageData.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698