Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(52)

Issue 2472703003: Load the GL_KHR_debug entry points and log messages they produce. (Closed)

Created:
4 years, 1 month ago by Geoff Lang
Modified:
4 years, 1 month ago
Reviewers:
Oliver Chang, piman
CC:
chromium-reviews, jam, darin-cc_chromium.org, piman+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Load the GL_KHR_debug entry points and log messages they produce. BUG=661603 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Committed: https://crrev.com/326c851cbb14cc379fa6516ef2cf73f18f8778f0 Cr-Commit-Position: refs/heads/master@{#429589}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Update window system string #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1970 lines, -9 lines) Patch
M content/common/gpu_host_messages.h View 1 chunk +1 line, -0 lines 0 comments Download
M content/public/browser/gpu_utils.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M gpu/command_buffer/service/feature_info.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M gpu/command_buffer/service/feature_info.cc View 1 1 chunk +4 lines, -0 lines 0 comments Download
M gpu/command_buffer/service/gl_utils.h View 1 chunk +10 lines, -0 lines 0 comments Download
M gpu/command_buffer/service/gl_utils.cc View 1 2 chunks +86 lines, -0 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder.cc View 1 1 chunk +5 lines, -0 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder_passthrough.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M gpu/command_buffer/service/gpu_preferences.h View 1 1 chunk +3 lines, -0 lines 0 comments Download
M gpu/command_buffer/service/gpu_switches.h View 1 chunk +1 line, -0 lines 0 comments Download
M gpu/command_buffer/service/gpu_switches.cc View 1 chunk +3 lines, -0 lines 0 comments Download
A + third_party/khronos/GLES3/gl32.h View 9 chunks +650 lines, -5 lines 0 comments Download
M ui/gl/generate_bindings.py View 8 chunks +68 lines, -1 line 0 comments Download
M ui/gl/gl_bindings_api_autogen_gl.h View 6 chunks +42 lines, -0 lines 0 comments Download
M ui/gl/gl_bindings_autogen_gl.h View 24 chunks +114 lines, -0 lines 0 comments Download
M ui/gl/gl_bindings_autogen_gl.cc View 43 chunks +562 lines, -1 line 0 comments Download
M ui/gl/gl_bindings_autogen_mock.h View 6 chunks +88 lines, -0 lines 0 comments Download
M ui/gl/gl_bindings_autogen_mock.cc View 12 chunks +237 lines, -0 lines 0 comments Download
M ui/gl/gl_enums_implementation_autogen.h View 1 chunk +2 lines, -2 lines 0 comments Download
M ui/gl/gl_mock_autogen_gl.h View 6 chunks +43 lines, -0 lines 0 comments Download
M ui/gl/gl_stub_autogen_gl.h View 6 chunks +43 lines, -0 lines 0 comments Download

Messages

Total messages: 18 (11 generated)
Geoff Lang
PTAL ochang: Please check the new member I've added to the IPC struct
4 years, 1 month ago (2016-11-02 17:05:17 UTC) #6
piman
lgtm https://codereview.chromium.org/2472703003/diff/1/gpu/command_buffer/service/gl_utils.cc File gpu/command_buffer/service/gl_utils.cc (right): https://codereview.chromium.org/2472703003/diff/1/gpu/command_buffer/service/gl_utils.cc#newcode21 gpu/command_buffer/service/gl_utils.cc:21: return "Windows"; nit: "Window System" ?
4 years, 1 month ago (2016-11-02 18:46:53 UTC) #9
Oliver Chang
lgtm
4 years, 1 month ago (2016-11-02 19:32:34 UTC) #10
Geoff Lang
https://codereview.chromium.org/2472703003/diff/1/gpu/command_buffer/service/gl_utils.cc File gpu/command_buffer/service/gl_utils.cc (right): https://codereview.chromium.org/2472703003/diff/1/gpu/command_buffer/service/gl_utils.cc#newcode21 gpu/command_buffer/service/gl_utils.cc:21: return "Windows"; On 2016/11/02 18:46:53, piman wrote: > nit: ...
4 years, 1 month ago (2016-11-03 14:16:14 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2472703003/20001
4 years, 1 month ago (2016-11-03 14:16:53 UTC) #14
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 1 month ago (2016-11-03 15:12:01 UTC) #16
commit-bot: I haz the power
4 years, 1 month ago (2016-11-03 15:40:51 UTC) #18
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/326c851cbb14cc379fa6516ef2cf73f18f8778f0
Cr-Commit-Position: refs/heads/master@{#429589}

Powered by Google App Engine
This is Rietveld 408576698