Source/modules/serviceworkers/ServiceWorkerContainer.cpp - Issue 247263010: ServiceWorker: Wait for registration promise to resolve before changing states.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/modules/serviceworkers/ServiceWorkerContainer.cpp

Issue 247263010: ServiceWorker: Wait for registration promise to resolve before changing states. (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: yhirano comments Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « Source/modules/serviceworkers/ServiceWorkerClients.cpp ('k') | Source/modules/serviceworkers/ServiceWorkerError.h » ('j') | public/platform/WebServiceWorker.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/modules/serviceworkers/ServiceWorkerContainer.cpp

diff --git a/Source/modules/serviceworkers/ServiceWorkerContainer.cpp b/Source/modules/serviceworkers/ServiceWorkerContainer.cpp

index b691afde70a24a87424397a83edc457e967b655b..0d6165a51c6c7b76e8db7646cfef85fa0d036711 100644

--- a/Source/modules/serviceworkers/ServiceWorkerContainer.cpp

+++ b/Source/modules/serviceworkers/ServiceWorkerContainer.cpp

@@ -99,10 +99,10 @@ ScriptPromise ServiceWorkerContainer::registerServiceWorker(ExecutionContext* ex

class UndefinedValue {

public:

typedef WebServiceWorker WebType;

- static v8::Handle<v8::Value> from(NewScriptState* scriptState, WebServiceWorker* worker)

+ static V8UndefinedType from(ScriptPromiseResolverWithContext* resolver, WebServiceWorker* worker)

{

ASSERT(!worker); // Anything passed here will be leaked.

- return v8::Undefined(scriptState->isolate());

+ return V8UndefinedType();

}

private: