ServiceWorker: Wait for registration promise to resolve before changing states.

public/platform/WebServiceWorker.h

Index: public/platform/WebServiceWorker.h
diff --git a/public/platform/WebServiceWorker.h b/public/platform/WebServiceWorker.h
index 56d1557b3458330a62ae0611738a5bb3b47627c7..cd31d7e899f6730c1d34b558902a1ccce54bf8dc 100644
--- a/public/platform/WebServiceWorker.h
+++ b/public/platform/WebServiceWorker.h
@@ -53,6 +53,9 @@ public:
     // WebServiceWorker.
     virtual void setProxy(WebServiceWorkerProxy*) { }
 
+    // Sets the state. This should only be called by the WebServiceWorkerProxy.
+    virtual void setState(blink::WebServiceWorkerState) { }

[michaeln1, 2014/04/24 21:15:08]

This webkit api is kinda convoluted? The proxy has an onStateChanged(st) method
to inform blink, this class has both a setter for blink to inform chromium, and
a getter for blink to query chromium. Hmmm...

If all you're looking at is this api, you'd be left wondering wth is up with
this, who/what exactly is the purveyor of truth regarding this 'state' junk?

What if this was rearranged a little? Here's a mental model. The blink-side can
be ready for state change events, but initially it might not be ready. When its
not ready, the chrome-side will defer making state changes (and instead queue
them up), so WebServiceWorker::state() will not mutate and
WebServiceWorkerProxy::dispatchStateChangeEvent() will not be called. When the
blink-side becomes ready, the chrome-side flushes the queued up changes by
updating its internal state and calling dispatchStateChangeEvent() for each
queue change.

So a webkit api that looks closer to...

// State changes are queued up until the blink-side is ready for them.
bool WebServiceWorkerProxy::isReady()

// Lets the chromium-side know that the blink-side has become ready or
// perhaps toggled back to not ready.
bool WebServiceWorker::proxyReadyChanged();

[falken, 2014/04/25 01:13:11]

Good idea, things would be clearer this way and I think it should work. I'll
take a stab at it and see how it turns out.

+
     virtual WebURL scope() const { return WebURL(); }
     virtual WebURL url() const { return WebURL(); }
     virtual WebServiceWorkerState state() const { return WebServiceWorkerStateUnknown; }