third_party/WebKit/Source/modules/sensor/AmbientLightSensor.h - Issue 2472403002: [Sensors] Align sensor reading attribute implementation with the specification

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/sensor/AmbientLightSensor.h

Issue 2472403002: [Sensors] Align sensor reading attribute implementation with the specification (Closed)

Patch Set: Comments from Tim Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/modules/sensor/AmbientLightSensor.h

diff --git a/third_party/WebKit/Source/modules/sensor/AmbientLightSensor.h b/third_party/WebKit/Source/modules/sensor/AmbientLightSensor.h

index 825e78d115b8ea0b6070dfc413577a9b439b2fca..9a7f3ad6019476a59efb08f6f7f127ef11c9320f 100644

--- a/third_party/WebKit/Source/modules/sensor/AmbientLightSensor.h

+++ b/third_party/WebKit/Source/modules/sensor/AmbientLightSensor.h

@@ -27,7 +27,7 @@ class AmbientLightSensor final : public Sensor {

private:

AmbientLightSensor(ScriptState*, const SensorOptions&, ExceptionState&);

// Sensor overrides.

- SensorReading* createSensorReading(SensorProxy*) override;

+ std::unique_ptr<SensorReadingFactory> createSensorReadingFactory() override;

SensorConfigurationPtr createSensorConfig(

const SensorOptions&,

const SensorConfiguration& defaultConfig) override;