Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(887)

Unified Diff: third_party/WebKit/Source/modules/sensor/AmbientLightSensor.cpp

Issue 2472403002: [Sensors] Align sensor reading attribute implementation with the specification (Closed)
Patch Set: Comments from Tim Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/modules/sensor/AmbientLightSensor.cpp
diff --git a/third_party/WebKit/Source/modules/sensor/AmbientLightSensor.cpp b/third_party/WebKit/Source/modules/sensor/AmbientLightSensor.cpp
index d124044da0da34ae8f0c2c8eaf7bbddf38d6fb9a..12af2edac73bf79b4e8300c54898c14106988bef 100644
--- a/third_party/WebKit/Source/modules/sensor/AmbientLightSensor.cpp
+++ b/third_party/WebKit/Source/modules/sensor/AmbientLightSensor.cpp
@@ -34,8 +34,10 @@ AmbientLightSensorReading* AmbientLightSensor::reading() const {
return static_cast<AmbientLightSensorReading*>(Sensor::reading());
}
-SensorReading* AmbientLightSensor::createSensorReading(SensorProxy* proxy) {
- return AmbientLightSensorReading::create(proxy);
+std::unique_ptr<SensorReadingFactory>
+AmbientLightSensor::createSensorReadingFactory() {
+ return std::unique_ptr<SensorReadingFactory>(
+ new SensorReadingFactoryImpl<AmbientLightSensorReading>());
}
auto AmbientLightSensor::createSensorConfig(

Powered by Google App Engine
This is Rietveld 408576698