Remove experiment support for PasswordManagerSettingsBehaviourChange

Remove experiment support for PasswordManagerSettingsBehaviourChange

The CL also fixes what appears to be a typo in PasswordManagerSettingsMigrationExperimentTest.IsSettingsMigrationOff: the call to EnforcePasswordManagerSettingsBehaviourChangeExperimentGroup should be a call to EnforcePasswordManagerSettingMigrationExperimentGroup.

BUG=662337
Committed: https://crrev.com/92648c89f03ae89685270ef2201a54a4a4155be3
Cr-Commit-Position: refs/heads/master@{#429888}

[vabr (Chromium), 2016-11-04 10:40:40]

The CQ bit was checked by vabr@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-04 10:41:00]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[vabr (Chromium), 2016-11-04 10:42:48]

Description was changed from

==========
Remove experiment support for PasswordManagerSettingsBehaviourChange

BUG=662337
==========

to

==========
Remove experiment support for PasswordManagerSettingsBehaviourChange

The CL also fixes what appears to be a typo in
PasswordManagerSettingsMigrationExperimentTest.IsSettingsMigrationOff: the call
to EnforcePasswordManagerSettingsBehaviourChangeExperimentGroup should be a call
to EnforcePasswordManagerSettingMigrationExperimentGroup.

BUG=662337
==========

[commit-bot: I haz the power, 2016-11-04 10:50:13]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-04 10:50:14]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[vabr (Chromium), 2016-11-04 11:16:38]

The CQ bit was checked by vabr@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-04 11:16:57]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-04 12:01:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-04 12:01:17]

Dry run: This issue passed the CQ dry run.

[vabr (Chromium), 2016-11-04 13:05:47]

Hi Vasilii,

PTAL.

Once this lands, I will also set expiration on the Finch config for the current
ToT version (56).

Thanks!
Vaclav

[vabr (Chromium), 2016-11-04 13:06:17]

vabr@chromium.org changed reviewers:
+ vasilii@chromium.org

[vabr (Chromium), 2016-11-04 13:06:17]

(Now with also sending this to your e-mail address. :))

Hi Vasilii,

PTAL.

Once this lands, I will also set expiration on the Finch config for the current
ToT version (56).

Thanks!
Vaclav

[vasilii, 2016-11-04 13:47:39]

lgtm

https://codereview.chromium.org/2472363002/diff/20001/chrome/browser/ui/passw...
File chrome/browser/ui/passwords/manage_passwords_view_utils_desktop_unittest.cc
(right):

https://codereview.chromium.org/2472363002/diff/20001/chrome/browser/ui/passw...
chrome/browser/ui/passwords/manage_passwords_view_utils_desktop_unittest.cc:103:
{"Smart Lock User no branding, migration active.",
Smart Lock User,

and below.

[vabr (Chromium), 2016-11-04 14:29:36]

Thanks!
Comment addressed, sending to the CQ.

Cheers,
Vaclav

https://codereview.chromium.org/2472363002/diff/20001/chrome/browser/ui/passw...
File chrome/browser/ui/passwords/manage_passwords_view_utils_desktop_unittest.cc
(right):

https://codereview.chromium.org/2472363002/diff/20001/chrome/browser/ui/passw...
chrome/browser/ui/passwords/manage_passwords_view_utils_desktop_unittest.cc:103:
{"Smart Lock User no branding, migration active.",
On 2016/11/04 13:47:38, vasilii wrote:
> Smart Lock User,
> 
> and below.

Done, also removed the full-stop from the first two to match the rest.

[vabr (Chromium), 2016-11-04 14:29:39]

The CQ bit was checked by vabr@chromium.org

[vabr (Chromium), 2016-11-04 14:29:39]

The patchset sent to the CQ was uploaded after l-g-t-m from vasilii@chromium.org
Link to the patchset: https://codereview.chromium.org/2472363002/#ps40001
(title: "Fix punctuation")

[commit-bot: I haz the power, 2016-11-04 14:29:49]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-04 15:17:44]

Description was changed from

==========
Remove experiment support for PasswordManagerSettingsBehaviourChange

The CL also fixes what appears to be a typo in
PasswordManagerSettingsMigrationExperimentTest.IsSettingsMigrationOff: the call
to EnforcePasswordManagerSettingsBehaviourChangeExperimentGroup should be a call
to EnforcePasswordManagerSettingMigrationExperimentGroup.

BUG=662337
==========

to

==========
Remove experiment support for PasswordManagerSettingsBehaviourChange

The CL also fixes what appears to be a typo in
PasswordManagerSettingsMigrationExperimentTest.IsSettingsMigrationOff: the call
to EnforcePasswordManagerSettingsBehaviourChangeExperimentGroup should be a call
to EnforcePasswordManagerSettingMigrationExperimentGroup.

BUG=662337
==========

[commit-bot: I haz the power, 2016-11-04 15:17:45]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-11-04 15:19:11]

Description was changed from

==========
Remove experiment support for PasswordManagerSettingsBehaviourChange

The CL also fixes what appears to be a typo in
PasswordManagerSettingsMigrationExperimentTest.IsSettingsMigrationOff: the call
to EnforcePasswordManagerSettingsBehaviourChangeExperimentGroup should be a call
to EnforcePasswordManagerSettingMigrationExperimentGroup.

BUG=662337
==========

to

==========
Remove experiment support for PasswordManagerSettingsBehaviourChange

The CL also fixes what appears to be a typo in
PasswordManagerSettingsMigrationExperimentTest.IsSettingsMigrationOff: the call
to EnforcePasswordManagerSettingsBehaviourChangeExperimentGroup should be a call
to EnforcePasswordManagerSettingMigrationExperimentGroup.

BUG=662337

Committed: https://crrev.com/92648c89f03ae89685270ef2201a54a4a4155be3
Cr-Commit-Position: refs/heads/master@{#429888}
==========

[commit-bot: I haz the power, 2016-11-04 15:19:12]

Patchset 3 (id:??) landed as
https://crrev.com/92648c89f03ae89685270ef2201a54a4a4155be3
Cr-Commit-Position: refs/heads/master@{#429888}