Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1620)

Unified Diff: components/password_manager/core/browser/password_manager_settings_migration_experiment_unittest.cc

Issue 2472363002: Remove experiment support for PasswordManagerSettingsBehaviourChange (Closed)
Patch Set: Fix punctuation Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/password_manager/core/browser/password_manager_settings_migration_experiment.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/password_manager/core/browser/password_manager_settings_migration_experiment_unittest.cc
diff --git a/components/password_manager/core/browser/password_manager_settings_migration_experiment_unittest.cc b/components/password_manager/core/browser/password_manager_settings_migration_experiment_unittest.cc
index 3c924d7a0de6c8cc81c1175c54187e8b032b0be8..81d8d42d337244062314143c5532bff18231b280 100644
--- a/components/password_manager/core/browser/password_manager_settings_migration_experiment_unittest.cc
+++ b/components/password_manager/core/browser/password_manager_settings_migration_experiment_unittest.cc
@@ -16,13 +16,6 @@ const char kPasswordManagerSettingMigrationFieldTrialName[] =
const char kEnabledPasswordManagerSettingsMigrationGroupName[] = "Enable";
const char kDisablePasswordManagerSettingsMigrationGroupName[] = "Disable";
-const char kPasswordManagerSettingsBehaviourChangeFieldTrialName[] =
- "PasswordManagerSettingsBehaviourChange";
-const char kPasswordManagerSettingsBehaviourChangeEnabledGroupName[] =
- "PasswordManagerSettingsBehaviourChange.Active";
-const char kPasswordManagerSettingsBehaviourChangeDisabledGroupName[] =
- "PasswordManagerSettingsBehaviourChange.NotActive";
-
} // namespace
namespace password_manager {
@@ -37,12 +30,6 @@ class PasswordManagerSettingsMigrationExperimentTest : public testing::Test {
kPasswordManagerSettingMigrationFieldTrialName, name));
}
- void EnforcePasswordManagerSettingsBehaviourChangeExperimentGroup(
- const char* name) {
- ASSERT_TRUE(base::FieldTrialList::CreateFieldTrial(
- kPasswordManagerSettingsBehaviourChangeFieldTrialName, name));
- }
-
protected:
base::FieldTrialList field_trial_list_;
@@ -56,23 +43,9 @@ TEST_F(PasswordManagerSettingsMigrationExperimentTest, IsSettingsMigrationOn) {
}
TEST_F(PasswordManagerSettingsMigrationExperimentTest, IsSettingsMigrationOff) {
- EnforcePasswordManagerSettingsBehaviourChangeExperimentGroup(
+ EnforcePasswordManagerSettingMigrationExperimentGroup(
kDisablePasswordManagerSettingsMigrationGroupName);
EXPECT_FALSE(IsSettingsMigrationActive());
}
-TEST_F(PasswordManagerSettingsMigrationExperimentTest,
- IsBehaviourChangeEnabled) {
- EnforcePasswordManagerSettingsBehaviourChangeExperimentGroup(
- kPasswordManagerSettingsBehaviourChangeEnabledGroupName);
- EXPECT_TRUE(IsSettingsBehaviorChangeActive());
-}
-
-TEST_F(PasswordManagerSettingsMigrationExperimentTest,
- IsBehaviourChangeDisabled) {
- EnforcePasswordManagerSettingsBehaviourChangeExperimentGroup(
- kPasswordManagerSettingsBehaviourChangeDisabledGroupName);
- EXPECT_FALSE(IsSettingsBehaviorChangeActive());
-}
-
} // namespace password_manager
« no previous file with comments | « components/password_manager/core/browser/password_manager_settings_migration_experiment.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698