Improvements to build_command_buffer.py

Improvements to build_command_buffer.py

Remove subdir thing for Linux. It's incorrect.

Make the script able to take extra GN args.

Default to a custom gn output dir for the command buffer build.

Default to a release build of the command buffer.

Document that the script overwrites the gn args on each run.
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2472343003

Committed: https://skia.googlesource.com/skia/+/795390bd881cb8a0a25b0805dd762ea4373a1c27

[bsalomon, 2016-11-04 15:36:52]

Description was changed from

==========
Improvements to build_command_buffer.py

Remove subdir thing for Linux. It's incorrect.

Make the script able to take extra GN args.

Default to a custom gn output dir for the command buffer build.

Default to a release build of the command buffer.

Document that the script overwrites the gn args on each run.
==========

to

==========
Improvements to build_command_buffer.py

Remove subdir thing for Linux. It's incorrect.

Make the script able to take extra GN args.

Default to a custom gn output dir for the command buffer build.

Default to a release build of the command buffer.

Document that the script overwrites the gn args on each run.
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2472343003
==========

[bsalomon, 2016-11-04 15:38:50]

bsalomon@google.com changed reviewers:
+ brianosman@google.com

[bsalomon, 2016-11-04 15:38:50]

It is still possible to use this to do a debug build of the command buffer by
using the --extra-gn-flags=is_debug=true which will override the default since
the extra args are appended rather than prepended.

https://codereview.chromium.org/2472343003/diff/1/infra/bots/recipe_modules/f...
File infra/bots/recipe_modules/flavor/gn_flavor.py (left):

https://codereview.chromium.org/2472343003/diff/1/infra/bots/recipe_modules/f...
infra/bots/recipe_modules/flavor/gn_flavor.py:30: '--chrome-build-type',
self.m.vars.configuration,
Now the bots use the new default output dir for the command buffer build.

[Brian Osman, 2016-11-04 16:56:39]

lgtm

[bsalomon, 2016-11-04 16:59:46]

The CQ bit was checked by bsalomon@google.com

[commit-bot: I haz the power, 2016-11-04 16:59:50]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-04 17:54:57]

Description was changed from

==========
Improvements to build_command_buffer.py

Remove subdir thing for Linux. It's incorrect.

Make the script able to take extra GN args.

Default to a custom gn output dir for the command buffer build.

Default to a release build of the command buffer.

Document that the script overwrites the gn args on each run.
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2472343003
==========

to

==========
Improvements to build_command_buffer.py

Remove subdir thing for Linux. It's incorrect.

Make the script able to take extra GN args.

Default to a custom gn output dir for the command buffer build.

Default to a release build of the command buffer.

Document that the script overwrites the gn args on each run.
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2472343003

Committed:
https://skia.googlesource.com/skia/+/795390bd881cb8a0a25b0805dd762ea4373a1c27
==========

[commit-bot: I haz the power, 2016-11-04 17:54:58]

Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/795390bd881cb8a0a25b0805dd762ea4373a1c27