infra/bots/recipe_modules/flavor/gn_flavor.py - Issue 2472343003: Improvements to build_command_buffer.py

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: infra/bots/recipe_modules/flavor/gn_flavor.py

Issue 2472343003: Improvements to build_command_buffer.py (Closed)

Patch Set: Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: infra/bots/recipe_modules/flavor/gn_flavor.py

diff --git a/infra/bots/recipe_modules/flavor/gn_flavor.py b/infra/bots/recipe_modules/flavor/gn_flavor.py

index c6eea7672e85b4d65d5ac9c3ffe907d20d22c992..a019de23571ddafe6b48c81a1cb781d9d5b16494 100644

--- a/infra/bots/recipe_modules/flavor/gn_flavor.py

+++ b/infra/bots/recipe_modules/flavor/gn_flavor.py

@@ -27,7 +27,6 @@ class GNFlavorUtils(default_flavor.DefaultFlavorUtils):

args=[

'--chrome-dir', self.m.vars.checkout_root,

'--output-dir', self.m.vars.skia_out.join(self.m.vars.configuration),

- '--chrome-build-type', self.m.vars.configuration,

bsalomon 2016/11/04 15:38:50 Now the bots use the new default output dir for th

'--no-sync', '--make-output-dir'])

def compile(self, unused_target, **kwargs):

« no previous file with comments | « no previous file | infra/bots/recipes/swarm_compile.expected/Build-Mac-Clang-x86_64-Debug-CommandBuffer.json » ('j') | no next file with comments »