Fix a bug of PopupAlignmentDelegate on non-primary display

Fix a bug of PopupAlignmentDelegate on non-primary display

Previously, PopupAlignmentDelegate assumed the display's y-axis origin is 0. But it is not true in case of non-primary display which is not vertically aligned with the primary display. This patch makes PopupAlignmentDelegate consider such a non-primary display and fixes the issue.

BUG=662198
TEST=none

Committed: https://crrev.com/6171d1a24ab95e88598cbd499cfd908b8819ecba
Cr-Commit-Position: refs/heads/master@{#430126}

[yoshiki, 2016-11-04 00:09:51]

The CQ bit was checked by yoshiki@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-04 00:10:38]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[yoshiki, 2016-11-04 00:15:02]

Description was changed from

==========
.

BUG=
==========

to

==========
Fix a bug of PopupAlignmentDelegate on non-primary display

PopupAlignmentDelegate assumed the display's y-axis origin is 0. But it is not
true on non-primary display which is not vertically aligned with the primary
display. This patch makes PopupAlignmentDelegate consider such a non-primary
display.

BUG=662198
TEST=none
==========

[yoshiki, 2016-11-04 00:30:45]

Description was changed from

==========
Fix a bug of PopupAlignmentDelegate on non-primary display

PopupAlignmentDelegate assumed the display's y-axis origin is 0. But it is not
true on non-primary display which is not vertically aligned with the primary
display. This patch makes PopupAlignmentDelegate consider such a non-primary
display.

BUG=662198
TEST=none
==========

to

==========
Fix a bug of PopupAlignmentDelegate on non-primary display

Previously, PopupAlignmentDelegate assumed the display's y-axis origin is 0. But
it is not true in case of non-primary display which is not vertically aligned
with the primary display. This patch makes PopupAlignmentDelegate consider such
a non-primary display and fixes the issue.

BUG=662198
TEST=none
==========

[yoshiki, 2016-11-04 00:30:45]

yoshiki@chromium.org changed reviewers:
+ dewittj@chromium.org, oshima@chromium.org

[yoshiki, 2016-11-04 00:31:38]

yoshiki@chromium.org changed reviewers:
+ skuhne@chromium.org
- oshima@chromium.org

[yoshiki, 2016-11-04 00:32:31]

Stefan, PTAL at ash/common/system/web_notification/*.
Justin, PTAL at ui/message_center/views/*.

Thanks.

[commit-bot: I haz the power, 2016-11-04 03:57:01]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-04 03:57:01]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[Mr4D (OOO till 08-26), 2016-11-04 14:03:12]

a/c/s/w lgtm - But please consider passing back the entire bounds - if this
might ever come handy. If not - ignore my comment.

https://codereview.chromium.org/2472233002/diff/1/ash/common/system/web_notif...
File ash/common/system/web_notification/ash_popup_alignment_delegate.cc (right):

https://codereview.chromium.org/2472233002/diff/1/ash/common/system/web_notif...
ash/common/system/web_notification/ash_popup_alignment_delegate.cc:93: int
AshPopupAlignmentDelegate::GetWorkAreaTop() const {
Is there a reason for not exporting the entire work_area?
(I mean we have now top and bottom - so no need for left and right?)

[dewittj, 2016-11-04 20:18:37]

also lgtm, agree that it's probably right to expose the whole work area.  Or at
least a std::pair representing the extent of the work area Y values.

[yoshiki, 2016-11-04 20:37:05]

The CQ bit was checked by yoshiki@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-04 20:37:47]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-04 22:10:07]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-04 22:10:07]

Dry run: This issue passed the CQ dry run.

[yoshiki, 2016-11-05 01:56:54]

Thank you for reviewing. Let me submit.

https://codereview.chromium.org/2472233002/diff/1/ash/common/system/web_notif...
File ash/common/system/web_notification/ash_popup_alignment_delegate.cc (right):

https://codereview.chromium.org/2472233002/diff/1/ash/common/system/web_notif...
ash/common/system/web_notification/ash_popup_alignment_delegate.cc:93: int
AshPopupAlignmentDelegate::GetWorkAreaTop() const {
On 2016/11/04 14:03:12, Mr4D wrote:
> Is there a reason for not exporting the entire work_area?
> (I mean we have now top and bottom - so no need for left and right?)

Nice idea! Done.

[yoshiki, 2016-11-05 01:57:03]

The CQ bit was checked by yoshiki@chromium.org

[yoshiki, 2016-11-05 01:57:03]

The patchset sent to the CQ was uploaded after l-g-t-m from skuhne@chromium.org,
dewittj@chromium.org
Link to the patchset: https://codereview.chromium.org/2472233002/#ps20001
(title: "Addressed comment: returning a rect instead of top ")

[commit-bot: I haz the power, 2016-11-05 01:57:24]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-05 02:03:40]

Description was changed from

==========
Fix a bug of PopupAlignmentDelegate on non-primary display

Previously, PopupAlignmentDelegate assumed the display's y-axis origin is 0. But
it is not true in case of non-primary display which is not vertically aligned
with the primary display. This patch makes PopupAlignmentDelegate consider such
a non-primary display and fixes the issue.

BUG=662198
TEST=none
==========

to

==========
Fix a bug of PopupAlignmentDelegate on non-primary display

Previously, PopupAlignmentDelegate assumed the display's y-axis origin is 0. But
it is not true in case of non-primary display which is not vertically aligned
with the primary display. This patch makes PopupAlignmentDelegate consider such
a non-primary display and fixes the issue.

BUG=662198
TEST=none
==========

[commit-bot: I haz the power, 2016-11-05 02:03:41]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-11-05 02:06:25]

Description was changed from

==========
Fix a bug of PopupAlignmentDelegate on non-primary display

Previously, PopupAlignmentDelegate assumed the display's y-axis origin is 0. But
it is not true in case of non-primary display which is not vertically aligned
with the primary display. This patch makes PopupAlignmentDelegate consider such
a non-primary display and fixes the issue.

BUG=662198
TEST=none
==========

to

==========
Fix a bug of PopupAlignmentDelegate on non-primary display

Previously, PopupAlignmentDelegate assumed the display's y-axis origin is 0. But
it is not true in case of non-primary display which is not vertically aligned
with the primary display. This patch makes PopupAlignmentDelegate consider such
a non-primary display and fixes the issue.

BUG=662198
TEST=none

Committed: https://crrev.com/6171d1a24ab95e88598cbd499cfd908b8819ecba
Cr-Commit-Position: refs/heads/master@{#430126}
==========

[commit-bot: I haz the power, 2016-11-05 02:06:26]

Patchset 2 (id:??) landed as
https://crrev.com/6171d1a24ab95e88598cbd499cfd908b8819ecba
Cr-Commit-Position: refs/heads/master@{#430126}