ash/common/system/web_notification/ash_popup_alignment_delegate.h - Issue 2472233002: Fix a bug of PopupAlignmentDelegate on non-primary display

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ash/common/system/web_notification/ash_popup_alignment_delegate.h

Issue 2472233002: Fix a bug of PopupAlignmentDelegate on non-primary display (Closed)

Patch Set: Addressed comment: returning a rect instead of top Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ash/common/system/web_notification/ash_popup_alignment_delegate.h

diff --git a/ash/common/system/web_notification/ash_popup_alignment_delegate.h b/ash/common/system/web_notification/ash_popup_alignment_delegate.h

index 0f2fd31d7f7bde0c1339d2c309cdb1941021b647..a1b3c6edf551d1ffb0cd6390590c5e893fb8d01a 100644

--- a/ash/common/system/web_notification/ash_popup_alignment_delegate.h

+++ b/ash/common/system/web_notification/ash_popup_alignment_delegate.h

@@ -51,7 +51,7 @@ class ASH_EXPORT AshPopupAlignmentDelegate

// Overridden from message_center::PopupAlignmentDelegate:

int GetToastOriginX(const gfx::Rect& toast_bounds) const override;

int GetBaseLine() const override;

- int GetWorkAreaBottom() const override;

+ gfx::Rect GetWorkArea() const override;

bool IsTopDown() const override;

bool IsFromLeft() const override;

void RecomputeAlignment(const display::Display& display) override;

« no previous file with comments | « no previous file | ash/common/system/web_notification/ash_popup_alignment_delegate.cc » ('j') | no next file with comments »