Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(661)

Unified Diff: chrome/test/data/firefox_profile/README

Issue 247223003: Parsed search.json for importing search engine settings from FireFox. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Restored kFirefoxKeywords and updated logic to import installed search engines along with default o… Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/importer/firefox_importer_browsertest.cc ('k') | chrome/test/data/firefox_profile/cert8.db » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/test/data/firefox_profile/README
diff --git a/chrome/test/data/firefox_profile/README b/chrome/test/data/firefox_profile/README
new file mode 100644
index 0000000000000000000000000000000000000000..f2f08dbcf9babb33baea0f16b34937569204d8df
--- /dev/null
+++ b/chrome/test/data/firefox_profile/README
@@ -0,0 +1,19 @@
+This directory is created to hold test data for Firefox importer browser tests.
+
+Since Firefox 3.5, instead of search.sqlite, all search engines are stored in
+search.json. The test data in this directory is intended for Firefox 3.5 and
+later.
+
+The search.json is grabbed from profile directory of Firefox 28.0 that runs in
+Ubuntu 12.04.4 LTS. To make this test search.json light weight, the keys
+|_iconURL| and |_iconMapObj| are removed from each search engines' dictionary.
+Moreover, each list of |engines| is updated to respect existing |kFirefoxKeywords|.
Ilya Sherman 2014/05/06 04:21:49 nit: Please wrap to 80 columns per line.
Tapu Ghose 2014/05/06 05:18:53 I should be more careful. Usually, I run "git cl f
Ilya Sherman 2014/05/06 19:00:12 Yeah, I think "git cl format" only formats C++ fil
+Please NOTE that values of |filePath| is dependant on workstation. They NEED to be
Ilya Sherman 2014/05/06 04:21:49 nit: Ditto here.
+updated in order to pass the test in corresponding workstation.
Ilya Sherman 2014/05/06 04:21:49 Hmm. Do you mean that the test you're adding will
Tapu Ghose 2014/05/06 05:18:53 No. The test should run for all platforms. Here, I
Ilya Sherman 2014/05/06 19:00:12 Is it possible to include the XML files in the tes
+
+All other files are grabbed from
+/src/chrome/test/data/firefox35_profile because
+
+1) They respect the existing |kFirefoxBookmarks|, |kFirefoxPasswords|
+of firefox_importer_browsertests.cc.
+2) Unlike search.sqlite, their behavior have not changed.
« no previous file with comments | « chrome/browser/importer/firefox_importer_browsertest.cc ('k') | chrome/test/data/firefox_profile/cert8.db » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698