chrome/test/data/firefox_profile/README - Issue 247223003: Parsed search.json for importing search engine settings from FireFox.

Side by Side Diff: chrome/test/data/firefox_profile/README

Issue 247223003: Parsed search.json for importing search engine settings from FireFox. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Restored kFirefoxKeywords and updated logic to import installed search engines along with default o… Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 This directory is created to hold test data for Firefox importer browser tests.

	2

	3 Since Firefox 3.5, instead of search.sqlite, all search engines are stored in

	4 search.json. The test data in this directory is intended for Firefox 3.5 and

	5 later.

	6

	7 The search.json is grabbed from profile directory of Firefox 28.0 that runs in

	8 Ubuntu 12.04.4 LTS. To make this test search.json light weight, the keys

	9 \|_iconURL\| and \|_iconMapObj\| are removed from each search engines' dictionary.

	10 Moreover, each list of \|engines\| is updated to respect existing \|kFirefoxKeyword s\|.
	Ilya Sherman 2014/05/06 04:21:49 nit: Please wrap to 80 columns per line. nit: Please wrap to 80 columns per line. Tapu Ghose 2014/05/06 05:18:53 I should be more careful. Usually, I run "git cl f Show quoted text On 2014/05/06 04:21:49, Ilya Sherman wrote: > nit: Please wrap to 80 columns per line. I should be more careful. Usually, I run "git cl format" before committing. But occasionally it fails to format the codes. Ilya Sherman 2014/05/06 19:00:12 Yeah, I think "git cl format" only formats C++ fil Show quoted text On 2014/05/06 05:18:53, Tapu wrote: > On 2014/05/06 04:21:49, Ilya Sherman wrote: > > nit: Please wrap to 80 columns per line. > > I should be more careful. Usually, I run "git cl format" before committing. But > occasionally it fails to format the codes. Yeah, I think "git cl format" only formats C++ files. Thanks for fixing the wrapping here :)
	11 Please NOTE that values of \|filePath\| is dependant on workstation. They NEED to be
	Ilya Sherman 2014/05/06 04:21:49 nit: Ditto here. nit: Ditto here.
	12 updated in order to pass the test in corresponding workstation.
	Ilya Sherman 2014/05/06 04:21:49 Hmm. Do you mean that the test you're adding will Hmm. Do you mean that the test you're adding will only run correctly on a single platform? If so, it would be good to brainstorm how to make the test pass on all platforms. Tapu Ghose 2014/05/06 05:18:53 No. The test should run for all platforms. Here, I Show quoted text On 2014/05/06 04:21:49, Ilya Sherman wrote: > Hmm. Do you mean that the test you're adding will only run correctly on a > single platform? If so, it would be good to brainstorm how to make the test > pass on all platforms. No. The test should run for all platforms. Here, I meant to say that if you run the test in a try bot, then values of \|filePath\| in test search.json should be updated. In the test search.json, you can see that values of \|filePath\| is pointing to some of my local machine's directories. The values of \|filePath\| is the location of xml files for Firefox's search engines. Ilya Sherman 2014/05/06 19:00:12 Is it possible to include the XML files in the tes Show quoted text On 2014/05/06 05:18:53, Tapu wrote: > On 2014/05/06 04:21:49, Ilya Sherman wrote: > > Hmm. Do you mean that the test you're adding will only run correctly on a > > single platform? If so, it would be good to brainstorm how to make the test > > pass on all platforms. > > No. The test should run for all platforms. Here, I meant to say that if you run > the test in a try bot, then values of \|filePath\| in test search.json should be > updated. > In the test search.json, you can see that values of \|filePath\| is pointing to > some of my local machine's directories. The values of \|filePath\| is the location > of xml files for Firefox's search engines. Is it possible to include the XML files in the test directory, and to use relative file paths to those XML files? The test should be able to run successfully on all platforms without any changes to the data files. Once the test code is checked in to the tree, it will be run automatically (so that it can catch regressions :)), so we need to make sure that it works everywhere. Currently, the try bots from patch set 4 are showing failures on all platforms. (There are also many unrelated failures that you can safely ignore. Our infrastructure has lots of sources of flaky failures, which folks are gradually working on fixing.) Do those results give you enough information to debug and implement fixes?
	13

	14 All other files are grabbed from

	15 /src/chrome/test/data/firefox35_profile because

	16

	17 1) They respect the existing \|kFirefoxBookmarks\|, \|kFirefoxPasswords\|

	18 of firefox_importer_browsertests.cc.

	19 2) Unlike search.sqlite, their behavior have not changed.

OLD	NEW

« no previous file with comments | « chrome/browser/importer/firefox_importer_browsertest.cc ('k') | chrome/test/data/firefox_profile/cert8.db » ('j') | no next file with comments »