Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(407)

Issue 2472213005: DevTools: introduce "Track CSS Usage" experiment (Closed)

Created:
4 years, 1 month ago by valih
Modified:
4 years, 1 month ago
Reviewers:
caseq, alph, lushnikov
CC:
apavlov+blink_chromium.org, blink-reviews, caseq+blink_chromium.org, chromium-reviews, devtools-reviews_chromium.org, kozyatinskiy+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, pfeldman
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: introduce "Track CSS Usage" experiment This patch introduces the "Track CSS Usage" experiment. The experiment adds a new timeline setting "Track CSS". When enabled, the timeline recording tracks the usage of CSS rules and exposes this information through the Sources panel. BUG=663017 Committed: https://crrev.com/3e072f5d6d65ae7d9ee65b5937775eb158871a61 Cr-Commit-Position: refs/heads/master@{#431176}

Patch Set 1 #

Patch Set 2 : Unused CSS highlight in sources panel #

Total comments: 8

Patch Set 3 : Unused CSS highlight in sources panel #

Patch Set 4 : Unused CSS highlight in sources panel #

Patch Set 5 : Unused CSS highlight in sources panel #

Patch Set 6 : Unused CSS highlight in sources panel #

Patch Set 7 : Unused CSS highlight in sources panel #

Total comments: 19

Patch Set 8 : Unused CSS highlight in sources panel #

Patch Set 9 : Unused CSS highlight in sources panel #

Total comments: 9

Patch Set 10 : Unused CSS highlight in sources panel #

Total comments: 6

Patch Set 11 : Unused CSS highlight in sources panel #

Patch Set 12 : Unused CSS highlight in sources panel #

Total comments: 3

Patch Set 13 : Unused CSS highlight in sources panel #

Patch Set 14 : Unused CSS highlight in sources panel #

Patch Set 15 : Unused CSS highlight in sources panel #

Total comments: 5

Patch Set 16 : Unused CSS highlight in sources panel #

Patch Set 17 : Unused CSS highlight in sources panel #

Unified diffs Side-by-side diffs Delta from patch set Stats (+246 lines, -7 lines) Patch
A third_party/WebKit/LayoutTests/inspector/tracing/highlight-in-source.html View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 1 chunk +60 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/inspector/tracing/highlight-in-source-expected.txt View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 1 chunk +8 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/inspector/tracing/resources/highlight-in-source.css View 1 2 3 4 5 6 7 8 9 10 11 12 1 chunk +24 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/devtools/BUILD.gn View 1 2 3 4 5 6 7 8 9 10 11 12 13 1 chunk +1 line, -0 lines 0 comments Download
A third_party/WebKit/Source/devtools/front_end/components_lazy/CoverageProfile.js View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 1 chunk +69 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/components_lazy/module.json View 1 2 3 4 5 6 7 1 chunk +7 lines, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/main/Main.js View 1 2 3 4 5 6 7 8 9 10 11 12 13 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/sdk/CSSModel.js View 1 2 3 4 5 6 7 8 9 10 11 12 13 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/text_editor/cmdevtools.css View 1 2 3 4 5 6 7 8 9 10 11 12 13 2 chunks +16 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/timeline/TimelineController.js View 1 2 3 4 5 6 7 8 9 10 11 12 13 6 chunks +43 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/timeline/TimelinePanel.js View 1 2 3 4 5 6 7 8 9 10 11 12 13 4 chunks +14 lines, -0 lines 0 comments Download

Messages

Total messages: 35 (9 generated)
valih
4 years, 1 month ago (2016-11-04 20:30:06 UTC) #2
caseq
https://codereview.chromium.org/2472213005/diff/20001/third_party/WebKit/Source/devtools/front_end/components_lazy/LineMarkingProfile.js File third_party/WebKit/Source/devtools/front_end/components_lazy/LineMarkingProfile.js (right): https://codereview.chromium.org/2472213005/diff/20001/third_party/WebKit/Source/devtools/front_end/components_lazy/LineMarkingProfile.js#newcode7 third_party/WebKit/Source/devtools/front_end/components_lazy/LineMarkingProfile.js:7: WebInspector.LineMarkingProfile = class { CoverageProfile? https://codereview.chromium.org/2472213005/diff/20001/third_party/WebKit/Source/devtools/front_end/devtools_compatibility.js File third_party/WebKit/Source/devtools/front_end/devtools_compatibility.js (right): ...
4 years, 1 month ago (2016-11-04 21:10:02 UTC) #3
valih
4 years, 1 month ago (2016-11-07 18:46:32 UTC) #4
valih
4 years, 1 month ago (2016-11-07 18:52:08 UTC) #5
valih
4 years, 1 month ago (2016-11-07 19:05:59 UTC) #7
valih
4 years, 1 month ago (2016-11-07 19:06:00 UTC) #8
valih
4 years, 1 month ago (2016-11-07 19:53:41 UTC) #9
caseq
+ lushnikov and alph on the gutter implementation https://codereview.chromium.org/2472213005/diff/120001/third_party/WebKit/Source/devtools/front_end/timeline/TimelinePanel.js File third_party/WebKit/Source/devtools/front_end/timeline/TimelinePanel.js (right): https://codereview.chromium.org/2472213005/diff/120001/third_party/WebKit/Source/devtools/front_end/timeline/TimelinePanel.js#newcode782 third_party/WebKit/Source/devtools/front_end/timeline/TimelinePanel.js:782: if ...
4 years, 1 month ago (2016-11-08 01:54:11 UTC) #11
alph
https://codereview.chromium.org/2472213005/diff/120001/third_party/WebKit/Source/devtools/front_end/components_lazy/CoverageProfile.js File third_party/WebKit/Source/devtools/front_end/components_lazy/CoverageProfile.js (right): https://codereview.chromium.org/2472213005/diff/120001/third_party/WebKit/Source/devtools/front_end/components_lazy/CoverageProfile.js#newcode4 third_party/WebKit/Source/devtools/front_end/components_lazy/CoverageProfile.js:4: /** empty line plz https://codereview.chromium.org/2472213005/diff/120001/third_party/WebKit/Source/devtools/front_end/components_lazy/CoverageProfile.js#newcode5 third_party/WebKit/Source/devtools/front_end/components_lazy/CoverageProfile.js:5: * @unrestricted Can ...
4 years, 1 month ago (2016-11-08 17:10:25 UTC) #12
valih
4 years, 1 month ago (2016-11-08 20:07:33 UTC) #13
lushnikov
https://codereview.chromium.org/2472213005/diff/160001/third_party/WebKit/Source/devtools/front_end/components_lazy/CoverageProfile.js File third_party/WebKit/Source/devtools/front_end/components_lazy/CoverageProfile.js (right): https://codereview.chromium.org/2472213005/diff/160001/third_party/WebKit/Source/devtools/front_end/components_lazy/CoverageProfile.js#newcode41 third_party/WebKit/Source/devtools/front_end/components_lazy/CoverageProfile.js:41: this._files = new Map(); this is not a collection ...
4 years, 1 month ago (2016-11-09 00:45:31 UTC) #14
lushnikov
We also need a test! https://codereview.chromium.org/2472213005/diff/180001/third_party/WebKit/Source/devtools/front_end/components_lazy/CoverageProfile.js File third_party/WebKit/Source/devtools/front_end/components_lazy/CoverageProfile.js (right): https://codereview.chromium.org/2472213005/diff/180001/third_party/WebKit/Source/devtools/front_end/components_lazy/CoverageProfile.js#newcode29 third_party/WebKit/Source/devtools/front_end/components_lazy/CoverageProfile.js:29: var fileInfo = this._coverageForURL.get(url); ...
4 years, 1 month ago (2016-11-09 01:55:22 UTC) #15
valih
4 years, 1 month ago (2016-11-09 02:11:29 UTC) #16
valih
4 years, 1 month ago (2016-11-09 02:27:05 UTC) #17
caseq
Mostly looks good. Let's revert stray changes and add a test. It would also be ...
4 years, 1 month ago (2016-11-09 18:25:30 UTC) #18
valih
4 years, 1 month ago (2016-11-09 21:28:03 UTC) #19
valih
4 years, 1 month ago (2016-11-09 22:54:09 UTC) #20
valih
4 years, 1 month ago (2016-11-09 23:01:55 UTC) #21
caseq
https://codereview.chromium.org/2472213005/diff/270001/third_party/WebKit/LayoutTests/inspector/tracing/highlight-in-source-expected.txt File third_party/WebKit/LayoutTests/inspector/tracing/highlight-in-source-expected.txt (right): https://codereview.chromium.org/2472213005/diff/270001/third_party/WebKit/LayoutTests/inspector/tracing/highlight-in-source-expected.txt#newcode15 third_party/WebKit/LayoutTests/inspector/tracing/highlight-in-source-expected.txt:15: 1 This looks strange. Aren't those supposed to be ...
4 years, 1 month ago (2016-11-09 23:33:55 UTC) #22
valih
4 years, 1 month ago (2016-11-09 23:50:25 UTC) #23
valih
4 years, 1 month ago (2016-11-10 00:55:46 UTC) #24
caseq
lgtm, but please also get one from lushnikov!
4 years, 1 month ago (2016-11-10 00:58:01 UTC) #25
lushnikov
lgtm
4 years, 1 month ago (2016-11-10 01:32:21 UTC) #26
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2472213005/310001
4 years, 1 month ago (2016-11-10 01:42:54 UTC) #29
commit-bot: I haz the power
Committed patchset #17 (id:310001)
4 years, 1 month ago (2016-11-10 03:59:43 UTC) #31
commit-bot: I haz the power
4 years, 1 month ago (2016-11-10 04:12:04 UTC) #33
Message was sent while issue was closed.
Patchset 17 (id:??) landed as
https://crrev.com/3e072f5d6d65ae7d9ee65b5937775eb158871a61
Cr-Commit-Position: refs/heads/master@{#431176}

Powered by Google App Engine
This is Rietveld 408576698