third_party/WebKit/LayoutTests/inspector/tracing/highlight-in-source.html - Issue 2472213005: DevTools: introduce "Track CSS Usage" experiment

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/inspector/tracing/highlight-in-source.html

Issue 2472213005: DevTools: introduce "Track CSS Usage" experiment (Closed)

Patch Set: Unused CSS highlight in sources panel Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « no previous file | third_party/WebKit/LayoutTests/inspector/tracing/highlight-in-source-expected.txt » ('j') | third_party/WebKit/LayoutTests/inspector/tracing/highlight-in-source-expected.txt » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <html>

	2 <head>

	3 <script src="../../http/tests/inspector/inspector-test.js"></script>

	4 <script src="../../http/tests/inspector/timeline-test.js"></script>

	5 <script src="../../http/tests/inspector/debugger-test.js"></script>

	6 <script src="../../http/tests/inspector/sources-test.js"></script>

	7

	8 <link rel="stylesheet" type="text/css" href="resources/highlight-in-source.css">

	9 <script>

	10

	11 function test()

	12 {

	13 Runtime.experiments.enableForTest("timelineRuleUsageRecording");

	14

	15 var panel = WebInspector.panels.timeline;

	16 panel._markUnusedCSS.set(true);

	17

	18 InspectorTest.runTestSuite([

	19 function testMarking(next)

	20 {

	21 function printResults() {
	caseq 2016/11/09 23:33:55 { => next line (this still uses old style) Also, { => next line (this still uses old style) Also, we prefer the declaration order that would match execution order, so InspectorTest.startTimeline(timelineStarted) function timelineStarted() { } ... function printResults() { }
	22 WebInspector.inspectorView.showPanel("sources").then(

	23 InspectorTest.showScriptSource("highlight-in-source.css", () => setTimeout(didShowScriptSource, 0)));
	caseq 2016/11/09 23:33:55 Passing the result of showScriptSource() to Promis Passing the result of showScriptSource() to Promise.then() does not make sense. Also, why do you need setTimeout()?
	24

	25 function didShowScriptSource(sourceFrame) {
	caseq 2016/11/09 23:33:55 { => next line { => next line
	26 var lines = Array.prototype.map.call(document.querySelectorA ll(".text-editor-line-marker-coverage"),

	27 e => e.parentElement.pr eviousSibling.textContent);

	28

	29 InspectorTest.addResult("Number of lines: " + lines.length);
	caseq 2016/11/09 23:33:55 drop this, and just do InspectorTest.addResults(li drop this, and just do InspectorTest.addResults(lines)
	30

	31 for(line of lines)

	32 InspectorTest.addResults(line);

	33

	34 next();

	35 }

	36 }

	37

	38 function timelineStarted()

	39 {

	40 InspectorTest.stopTimeline(printResults);

	41 }

	42

	43 InspectorTest.startTimeline(timelineStarted);

	44 }

	45 ]);

	46 }

	47 </script>

	48 </head>

	49 <p id="id">PASS</p>

	50 <body onload="runTest()">

	51 <p>Tests the CSS highlight in sources after the timeline recording finishes.</p>

	52 </body>

	53 </html>

OLD	NEW