Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(425)

Unified Diff: content/browser/indexed_db/indexed_db_transaction_coordinator.h

Issue 2472213003: [IndexedDB] Refactoring to remove ref ptrs and host transaction ids. (Closed)
Patch Set: updated unittests Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/indexed_db/indexed_db_transaction_coordinator.h
diff --git a/content/browser/indexed_db/indexed_db_transaction_coordinator.h b/content/browser/indexed_db/indexed_db_transaction_coordinator.h
index c75d14101e37e578b6033f70c99f411e3dcfc33b..cf6415789f45c72eb3a9feeeb6cd274b27a6929d 100644
--- a/content/browser/indexed_db/indexed_db_transaction_coordinator.h
+++ b/content/browser/indexed_db/indexed_db_transaction_coordinator.h
@@ -10,10 +10,10 @@
#include <map>
#include <memory>
#include <set>
+#include <unordered_map>
cmumford 2016/11/04 23:33:13 Unused.
dmurph 2016/11/07 20:05:23 Done.
#include <vector>
#include "base/macros.h"
-#include "base/memory/ref_counted.h"
#include "content/browser/indexed_db/list_set.h"
namespace content {
@@ -27,7 +27,7 @@ class IndexedDBTransactionCoordinator {
~IndexedDBTransactionCoordinator();
// Called by transactions as they start and finish.
- void DidCreateTransaction(scoped_refptr<IndexedDBTransaction> transaction);
+ void DidCreateTransaction(IndexedDBTransaction* transaction);
void DidFinishTransaction(IndexedDBTransaction* transaction);
bool IsRunningVersionChangeTransaction() const;
@@ -47,8 +47,8 @@ class IndexedDBTransactionCoordinator {
// Transactions in different states are grouped below.
// list_set is used to provide stable ordering; required by spec
// for the queue, convenience for diagnostics for the rest.
- list_set<scoped_refptr<IndexedDBTransaction>> queued_transactions_;
- list_set<scoped_refptr<IndexedDBTransaction>> started_transactions_;
+ list_set<IndexedDBTransaction*> queued_transactions_;
+ list_set<IndexedDBTransaction*> started_transactions_;
DISALLOW_COPY_AND_ASSIGN(IndexedDBTransactionCoordinator);
};

Powered by Google App Engine
This is Rietveld 408576698