[IndexedDB] Refactoring to remove ref ptrs and host transaction ids.

content/browser/indexed_db/indexed_db_transaction_coordinator.cc

Index: content/browser/indexed_db/indexed_db_transaction_coordinator.cc
diff --git a/content/browser/indexed_db/indexed_db_transaction_coordinator.cc b/content/browser/indexed_db/indexed_db_transaction_coordinator.cc
index c7d171bca65a63123176d77225b04db123773408..5617628e619fdda92e753bc24377f814bb897324 100644
--- a/content/browser/indexed_db/indexed_db_transaction_coordinator.cc
+++ b/content/browser/indexed_db/indexed_db_transaction_coordinator.cc
@@ -18,7 +18,7 @@ IndexedDBTransactionCoordinator::~IndexedDBTransactionCoordinator() {
 }
 
 void IndexedDBTransactionCoordinator::DidCreateTransaction(
-    scoped_refptr<IndexedDBTransaction> transaction) {
+    IndexedDBTransaction* transaction) {
   DCHECK(!queued_transactions_.count(transaction));
   DCHECK(!started_transactions_.count(transaction));
   DCHECK_EQ(IndexedDBTransaction::CREATED, transaction->state());
@@ -65,11 +65,12 @@ bool IndexedDBTransactionCoordinator::IsActive(
 std::vector<const IndexedDBTransaction*>
 IndexedDBTransactionCoordinator::GetTransactions() const {
   std::vector<const IndexedDBTransaction*> result;
+  result.reserve(started_transactions_.size() + queued_transactions_.size());
 
   for (const auto& transaction : started_transactions_)
-    result.push_back(transaction.get());
+    result.push_back(transaction);

[jsbell, 2016/11/04 17:48:19]

Now that both types are raw pointers can this be result.insert(result.end(),
started_transactions_.begin(), started_transactions_.end()) ? Or does the const
prevent that?

[dmurph, 2016/11/04 22:52:25]

Done.

   for (const auto& transaction : queued_transactions_)
-    result.push_back(transaction.get());
+    result.push_back(transaction);
 
   return result;
 }
@@ -98,9 +99,9 @@ void IndexedDBTransactionCoordinator::ProcessQueuedTransactions() {
 
   auto it = queued_transactions_.begin();
   while (it != queued_transactions_.end()) {
-    scoped_refptr<IndexedDBTransaction> transaction = *it;
+    IndexedDBTransaction* transaction = *it;
     ++it;
-    if (CanStartTransaction(transaction.get(), locked_scope)) {
+    if (CanStartTransaction(transaction, locked_scope)) {
       DCHECK_EQ(IndexedDBTransaction::CREATED, transaction->state());
       queued_transactions_.erase(transaction);
       started_transactions_.insert(transaction);