Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(496)

Issue 2472213002: Ozone Linux: Fix build errors with chromeos==0 ozone_platform_drm=true (Closed)

Created:
4 years, 1 month ago by Tom (Use chromium acct)
Modified:
3 years, 11 months ago
Reviewers:
rjkroege, fwang, tonikitoo
CC:
chromium-reviews, kalyank, piman+watch_chromium.org, ozone-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Ozone Linux: Fix build errors with chromeos==0 ozone_platform_drm=true BUG=295089 R=rjkroege@chromium.org Committed: https://crrev.com/200f3beb2f118fca45dded1fa37dcee2727f704d Cr-Commit-Position: refs/heads/master@{#430100}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -2 lines) Patch
M ui/ozone/platform/drm/common/client_native_pixmap_dmabuf.cc View 1 chunk +1 line, -1 line 1 comment Download
M ui/ozone/platform/drm/gpu/drm_device.cc View 1 chunk +15 lines, -1 line 0 comments Download

Dependent Patchsets:

Messages

Total messages: 16 (8 generated)
Tom (Use chromium acct)
rjkroege@ PTAL I'm going to add ozone_platform_drm=true to the Ozone Linux builder, along with this ...
4 years, 1 month ago (2016-11-03 23:33:49 UTC) #1
Tom (Use chromium acct)
ping
4 years, 1 month ago (2016-11-04 17:33:40 UTC) #6
rjkroege
lgtm
4 years, 1 month ago (2016-11-05 00:17:17 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2472213002/1
4 years, 1 month ago (2016-11-05 00:20:36 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-05 00:48:23 UTC) #10
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/200f3beb2f118fca45dded1fa37dcee2727f704d Cr-Commit-Position: refs/heads/master@{#430100}
4 years, 1 month ago (2016-11-05 00:50:48 UTC) #12
tonikitoo
https://codereview.chromium.org/2472213002/diff/1/ui/ozone/platform/drm/common/client_native_pixmap_dmabuf.cc File ui/ozone/platform/drm/common/client_native_pixmap_dmabuf.cc (right): https://codereview.chromium.org/2472213002/diff/1/ui/ozone/platform/drm/common/client_native_pixmap_dmabuf.cc#newcode16 ui/ozone/platform/drm/common/client_native_pixmap_dmabuf.cc:16: #if defined(USE_OZONE) quick post mortem note: checking USE_OZONE seems ...
4 years, 1 month ago (2016-11-08 13:45:37 UTC) #14
fwang
3 years, 11 months ago (2017-01-18 13:46:18 UTC) #16
Message was sent while issue was closed.

          

Powered by Google App Engine
This is Rietveld 408576698