[TO 54] AudioRendererImpl: Don't advance time when rendering stops.

[TO 54] AudioRendererImpl: Don't advance time when rendering stops.

This is a quick work-around for the bug below. AudioRendererImpl was
recently improved to estimate time's advancing along the last rendered
audio buffer between Render() calls. This means the clock is capable of
still advancing a bit after OnBufferingStateChange indicates we've run
out of data. While tehcnically correct, the clocks advancing causes
blink to emit 'timeupdate' events with time advancing after emitting
'waiting' indicating that no data is buffered. This change stops the
clock once the render has underflowed.

Longterm, blink should be improved to gaurd against emitting timeupdate
after waiting. This larger change will be done separately to give it
time to bake. https://codereview.chromium.org/2425463002/

BUG=648710
Review-Url: https://codereview.chromium.org/2423903003
Cr-Commit-Position: refs/heads/master@{#425871}
(cherry picked from commit 9409db28cd7402d4bad8022afbd2b3719de72d08)

--ALSO--

[TO 54] AudioRendererImpl: Fix data race.

Previous CL introduced multithreaded access to |rendering_|.
https://codereview.chromium.org/2423903003/

BUG=657001, 648710
Review-Url: https://chromiumcodereview.appspot.com/2434003002
Cr-Commit-Position: refs/heads/master@{#426312}
(cherry picked from commit e2f429e24bdbcd8e8379b909879e2c729490e1c6)


TBR=sandersd@chromium.org

Committed: https://chromium.googlesource.com/chromium/src/+/273ba7eecd4b8654aae31b6980d8094a39b9a392

[chcunningham, 2016-11-04 23:01:28]

Description was changed from

==========
[TO 54] AudioRendererImpl: Don't advance time when rendering stops.

This is a quick work-around for the bug below. AudioRendererImpl was
recently improved to estimate time's advancing along the last rendered
audio buffer between Render() calls. This means the clock is capable of
still advancing a bit after OnBufferingStateChange indicates we've run
out of data. While tehcnically correct, the clocks advancing causes
blink to emit 'timeupdate' events with time advancing after emitting
'waiting' indicating that no data is buffered. This change stops the
clock once the render has underflowed.

Longterm, blink should be improved to gaurd against emitting timeupdate
after waiting. This larger change will be done separately to give it
time to bake. https://codereview.chromium.org/2425463002/

BUG=648710

Review-Url: https://codereview.chromium.org/2423903003
Cr-Commit-Position: refs/heads/master@{#425871}
(cherry picked from commit 9409db28cd7402d4bad8022afbd2b3719de72d08)

--ALSO--

[TO 54] AudioRendererImpl: Fix data race.

Previous CL introduced multithreaded access to |rendering_|.
https://codereview.chromium.org/2423903003/

BUG=657001,648710

Review-Url: https://chromiumcodereview.appspot.com/2434003002
Cr-Commit-Position: refs/heads/master@{#426312}
(cherry picked from commit e2f429e24bdbcd8e8379b909879e2c729490e1c6)
==========

to

==========
[TO 54] AudioRendererImpl: Don't advance time when rendering stops.

This is a quick work-around for the bug below. AudioRendererImpl was
recently improved to estimate time's advancing along the last rendered
audio buffer between Render() calls. This means the clock is capable of
still advancing a bit after OnBufferingStateChange indicates we've run
out of data. While tehcnically correct, the clocks advancing causes
blink to emit 'timeupdate' events with time advancing after emitting
'waiting' indicating that no data is buffered. This change stops the
clock once the render has underflowed.

Longterm, blink should be improved to gaurd against emitting timeupdate
after waiting. This larger change will be done separately to give it
time to bake. https://codereview.chromium.org/2425463002/

BUG=648710

Review-Url: https://codereview.chromium.org/2423903003
Cr-Commit-Position: refs/heads/master@{#425871}
(cherry picked from commit 9409db28cd7402d4bad8022afbd2b3719de72d08)

--ALSO--

[TO 54] AudioRendererImpl: Fix data race.

Previous CL introduced multithreaded access to |rendering_|.
https://codereview.chromium.org/2423903003/

BUG=657001,648710

Review-Url: https://chromiumcodereview.appspot.com/2434003002
Cr-Commit-Position: refs/heads/master@{#426312}
(cherry picked from commit e2f429e24bdbcd8e8379b909879e2c729490e1c6)
==========

[chcunningham, 2016-11-04 23:01:28]

chcunningham@chromium.org changed reviewers:
+ sandersd@chromium.org

[chcunningham, 2016-11-04 23:01:28]

Description was changed from

==========
[TO 54] AudioRendererImpl: Don't advance time when rendering stops.

This is a quick work-around for the bug below. AudioRendererImpl was
recently improved to estimate time's advancing along the last rendered
audio buffer between Render() calls. This means the clock is capable of
still advancing a bit after OnBufferingStateChange indicates we've run
out of data. While tehcnically correct, the clocks advancing causes
blink to emit 'timeupdate' events with time advancing after emitting
'waiting' indicating that no data is buffered. This change stops the
clock once the render has underflowed.

Longterm, blink should be improved to gaurd against emitting timeupdate
after waiting. This larger change will be done separately to give it
time to bake. https://codereview.chromium.org/2425463002/

BUG=648710

Review-Url: https://codereview.chromium.org/2423903003
Cr-Commit-Position: refs/heads/master@{#425871}
(cherry picked from commit 9409db28cd7402d4bad8022afbd2b3719de72d08)

--ALSO--

[TO 54] AudioRendererImpl: Fix data race.

Previous CL introduced multithreaded access to |rendering_|.
https://codereview.chromium.org/2423903003/

BUG=657001,648710

Review-Url: https://chromiumcodereview.appspot.com/2434003002
Cr-Commit-Position: refs/heads/master@{#426312}
(cherry picked from commit e2f429e24bdbcd8e8379b909879e2c729490e1c6)
==========

to

==========
[TO 54] AudioRendererImpl: Don't advance time when rendering stops.

This is a quick work-around for the bug below. AudioRendererImpl was
recently improved to estimate time's advancing along the last rendered
audio buffer between Render() calls. This means the clock is capable of
still advancing a bit after OnBufferingStateChange indicates we've run
out of data. While tehcnically correct, the clocks advancing causes
blink to emit 'timeupdate' events with time advancing after emitting
'waiting' indicating that no data is buffered. This change stops the
clock once the render has underflowed.

Longterm, blink should be improved to gaurd against emitting timeupdate
after waiting. This larger change will be done separately to give it
time to bake. https://codereview.chromium.org/2425463002/

BUG=648710

Review-Url: https://codereview.chromium.org/2423903003
Cr-Commit-Position: refs/heads/master@{#425871}
(cherry picked from commit 9409db28cd7402d4bad8022afbd2b3719de72d08)

--ALSO--

[TO 54] AudioRendererImpl: Fix data race.

Previous CL introduced multithreaded access to |rendering_|.
https://codereview.chromium.org/2423903003/

BUG=657001,648710

Review-Url: https://chromiumcodereview.appspot.com/2434003002
Cr-Commit-Position: refs/heads/master@{#426312}
(cherry picked from commit e2f429e24bdbcd8e8379b909879e2c729490e1c6)
==========

[chcunningham, 2016-11-04 23:01:28]

Description was changed from

==========
[TO 54] AudioRendererImpl: Don't advance time when rendering stops.

This is a quick work-around for the bug below. AudioRendererImpl was
recently improved to estimate time's advancing along the last rendered
audio buffer between Render() calls. This means the clock is capable of
still advancing a bit after OnBufferingStateChange indicates we've run
out of data. While tehcnically correct, the clocks advancing causes
blink to emit 'timeupdate' events with time advancing after emitting
'waiting' indicating that no data is buffered. This change stops the
clock once the render has underflowed.

Longterm, blink should be improved to gaurd against emitting timeupdate
after waiting. This larger change will be done separately to give it
time to bake. https://codereview.chromium.org/2425463002/

BUG=648710

Review-Url: https://codereview.chromium.org/2423903003
Cr-Commit-Position: refs/heads/master@{#425871}
(cherry picked from commit 9409db28cd7402d4bad8022afbd2b3719de72d08)

--ALSO--

[TO 54] AudioRendererImpl: Fix data race.

Previous CL introduced multithreaded access to |rendering_|.
https://codereview.chromium.org/2423903003/

BUG=657001,648710

Review-Url: https://chromiumcodereview.appspot.com/2434003002
Cr-Commit-Position: refs/heads/master@{#426312}
(cherry picked from commit e2f429e24bdbcd8e8379b909879e2c729490e1c6)
==========

to

==========
[TO 54] AudioRendererImpl: Don't advance time when rendering stops.

This is a quick work-around for the bug below. AudioRendererImpl was
recently improved to estimate time's advancing along the last rendered
audio buffer between Render() calls. This means the clock is capable of
still advancing a bit after OnBufferingStateChange indicates we've run
out of data. While tehcnically correct, the clocks advancing causes
blink to emit 'timeupdate' events with time advancing after emitting
'waiting' indicating that no data is buffered. This change stops the
clock once the render has underflowed.

Longterm, blink should be improved to gaurd against emitting timeupdate
after waiting. This larger change will be done separately to give it
time to bake. https://codereview.chromium.org/2425463002/

BUG=648710

Review-Url: https://codereview.chromium.org/2423903003
Cr-Commit-Position: refs/heads/master@{#425871}
(cherry picked from commit 9409db28cd7402d4bad8022afbd2b3719de72d08)

--ALSO--

[TO 54] AudioRendererImpl: Fix data race.

Previous CL introduced multithreaded access to |rendering_|.
https://codereview.chromium.org/2423903003/

BUG=657001,648710

Review-Url: https://chromiumcodereview.appspot.com/2434003002
Cr-Commit-Position: refs/heads/master@{#426312}
(cherry picked from commit e2f429e24bdbcd8e8379b909879e2c729490e1c6)
==========

[chcunningham, 2016-11-04 23:01:28]

chcunningham@chromium.org changed reviewers:
+ sandersd@chromium.org

[chcunningham, 2016-11-04 23:01:28]

chcunningham@chromium.org changed reviewers:
+ sandersd@chromium.org

[chcunningham, 2016-11-04 23:01:41]

Description was changed from

==========
[TO 54] AudioRendererImpl: Don't advance time when rendering stops.

This is a quick work-around for the bug below. AudioRendererImpl was
recently improved to estimate time's advancing along the last rendered
audio buffer between Render() calls. This means the clock is capable of
still advancing a bit after OnBufferingStateChange indicates we've run
out of data. While tehcnically correct, the clocks advancing causes
blink to emit 'timeupdate' events with time advancing after emitting
'waiting' indicating that no data is buffered. This change stops the
clock once the render has underflowed.

Longterm, blink should be improved to gaurd against emitting timeupdate
after waiting. This larger change will be done separately to give it
time to bake. https://codereview.chromium.org/2425463002/

BUG=648710

Review-Url: https://codereview.chromium.org/2423903003
Cr-Commit-Position: refs/heads/master@{#425871}
(cherry picked from commit 9409db28cd7402d4bad8022afbd2b3719de72d08)

--ALSO--

[TO 54] AudioRendererImpl: Fix data race.

Previous CL introduced multithreaded access to |rendering_|.
https://codereview.chromium.org/2423903003/

BUG=657001,648710

Review-Url: https://chromiumcodereview.appspot.com/2434003002
Cr-Commit-Position: refs/heads/master@{#426312}
(cherry picked from commit e2f429e24bdbcd8e8379b909879e2c729490e1c6)
==========

to

==========
[TO 54] AudioRendererImpl: Don't advance time when rendering stops.

This is a quick work-around for the bug below. AudioRendererImpl was
recently improved to estimate time's advancing along the last rendered
audio buffer between Render() calls. This means the clock is capable of
still advancing a bit after OnBufferingStateChange indicates we've run
out of data. While tehcnically correct, the clocks advancing causes
blink to emit 'timeupdate' events with time advancing after emitting
'waiting' indicating that no data is buffered. This change stops the
clock once the render has underflowed.

Longterm, blink should be improved to gaurd against emitting timeupdate
after waiting. This larger change will be done separately to give it
time to bake. https://codereview.chromium.org/2425463002/

BUG=648710

Review-Url: https://codereview.chromium.org/2423903003
Cr-Commit-Position: refs/heads/master@{#425871}
(cherry picked from commit 9409db28cd7402d4bad8022afbd2b3719de72d08)

--ALSO--

[TO 54] AudioRendererImpl: Fix data race.

Previous CL introduced multithreaded access to |rendering_|.
https://codereview.chromium.org/2423903003/

BUG=657001,648710

Review-Url: https://chromiumcodereview.appspot.com/2434003002
Cr-Commit-Position: refs/heads/master@{#426312}
(cherry picked from commit e2f429e24bdbcd8e8379b909879e2c729490e1c6)


TBR=sandersd@chromium.org
==========

[chcunningham, 2016-11-04 23:25:06]

Description was changed from

==========
[TO 54] AudioRendererImpl: Don't advance time when rendering stops.

This is a quick work-around for the bug below. AudioRendererImpl was
recently improved to estimate time's advancing along the last rendered
audio buffer between Render() calls. This means the clock is capable of
still advancing a bit after OnBufferingStateChange indicates we've run
out of data. While tehcnically correct, the clocks advancing causes
blink to emit 'timeupdate' events with time advancing after emitting
'waiting' indicating that no data is buffered. This change stops the
clock once the render has underflowed.

Longterm, blink should be improved to gaurd against emitting timeupdate
after waiting. This larger change will be done separately to give it
time to bake. https://codereview.chromium.org/2425463002/

BUG=648710

Review-Url: https://codereview.chromium.org/2423903003
Cr-Commit-Position: refs/heads/master@{#425871}
(cherry picked from commit 9409db28cd7402d4bad8022afbd2b3719de72d08)

--ALSO--

[TO 54] AudioRendererImpl: Fix data race.

Previous CL introduced multithreaded access to |rendering_|.
https://codereview.chromium.org/2423903003/

BUG=657001,648710

Review-Url: https://chromiumcodereview.appspot.com/2434003002
Cr-Commit-Position: refs/heads/master@{#426312}
(cherry picked from commit e2f429e24bdbcd8e8379b909879e2c729490e1c6)


TBR=sandersd@chromium.org
==========

to

==========
[TO 54] AudioRendererImpl: Don't advance time when rendering stops.

This is a quick work-around for the bug below. AudioRendererImpl was
recently improved to estimate time's advancing along the last rendered
audio buffer between Render() calls. This means the clock is capable of
still advancing a bit after OnBufferingStateChange indicates we've run
out of data. While tehcnically correct, the clocks advancing causes
blink to emit 'timeupdate' events with time advancing after emitting
'waiting' indicating that no data is buffered. This change stops the
clock once the render has underflowed.

Longterm, blink should be improved to gaurd against emitting timeupdate
after waiting. This larger change will be done separately to give it
time to bake. https://codereview.chromium.org/2425463002/

BUG=648710

Review-Url: https://codereview.chromium.org/2423903003
Cr-Commit-Position: refs/heads/master@{#425871}
(cherry picked from commit 9409db28cd7402d4bad8022afbd2b3719de72d08)

--ALSO--

[TO 54] AudioRendererImpl: Fix data race.

Previous CL introduced multithreaded access to |rendering_|.
https://codereview.chromium.org/2423903003/

BUG=657001,648710

Review-Url: https://chromiumcodereview.appspot.com/2434003002
Cr-Commit-Position: refs/heads/master@{#426312}
(cherry picked from commit e2f429e24bdbcd8e8379b909879e2c729490e1c6)


TBR=sandersd@chromium.org

Committed:
https://chromium.googlesource.com/chromium/src/+/273ba7eecd4b8654aae31b6980d8...
==========

[chcunningham, 2016-11-04 23:25:08]

Committed patchset #1 (id:1) manually as
273ba7eecd4b8654aae31b6980d8094a39b9a392.