Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(175)

Unified Diff: media/renderers/audio_renderer_impl_unittest.cc

Issue 2472183004: [TO 54] AudioRendererImpl: Don't advance time when rendering stops. (Closed)
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: media/renderers/audio_renderer_impl_unittest.cc
diff --git a/media/renderers/audio_renderer_impl_unittest.cc b/media/renderers/audio_renderer_impl_unittest.cc
index 9a3a89201a8e44b0f5958ec7f88d2689c5628839..bbb13b304a90f0a0b656ab7ddd6e2a0f2e250a83 100644
--- a/media/renderers/audio_renderer_impl_unittest.cc
+++ b/media/renderers/audio_renderer_impl_unittest.cc
@@ -755,7 +755,13 @@ TEST_F(AudioRendererImplTest, CurrentMediaTimeBehavior) {
StopTicking();
EXPECT_EQ(timestamp_helper.GetTimestamp(), CurrentMediaTime());
tick_clock_->Advance(kConsumptionDuration * 2);
- timestamp_helper.AddFrames(frames_to_consume.value);
+
+ // TODO(chcunningham): Uncomment the AddFrames() call below. AudioClock should
+ // be expected to advance time through the last rendered buffer's samples, but
+ // we've currently capped it to not advance time after ticking stops as a
+ // short term workaround for messy blink code. See longterm solution at
+ // http://crrev.com/2425463002.
+ // timestamp_helper.AddFrames(frames_to_consume.value);
EXPECT_EQ(timestamp_helper.GetTimestamp(), CurrentMediaTime());
}
« no previous file with comments | « media/renderers/audio_renderer_impl.cc ('k') | third_party/WebKit/LayoutTests/http/tests/media/video-play-stall.html » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698