Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(54)

Issue 2472183002: DevTools: Fix wrapping bugs in console (Closed)

Created:
4 years, 1 month ago by luoe
Modified:
4 years, 1 month ago
Reviewers:
lushnikov
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, pfeldman, kozyatinskiy+blink_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: Fix wrapping bugs in console Links in console messages now break on all letters, avoiding weird layouts. The class "console-message-text" used to refer to both the message content body and the anchor, but now it just refers to the content body. For trace messages, the expansion arrow is now a pseudo element on the content body, which is still clickable. Certain network errors were logged in the format "GET" + " " + url + description. This led to weird wrapping of the word "GET". By combining the empty space after "GET" with the word itself, the word no longer splits by letter. BUG=658096 Committed: https://crrev.com/ece209ef4fba37f1eb500fa61e128bac2c9a5e8f Cr-Commit-Position: refs/heads/master@{#430026}

Patch Set 1 #

Patch Set 2 : fix tests, remove unnecessary consoleView class #

Messages

Total messages: 18 (13 generated)
luoe
This CL is a continuation of: https://codereview.chromium.org/2472183002/ which was pushed before the big reformat. Per ...
4 years, 1 month ago (2016-11-03 21:51:16 UTC) #3
lushnikov
lgtm
4 years, 1 month ago (2016-11-03 22:18:04 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2472183002/20001
4 years, 1 month ago (2016-11-04 21:54:25 UTC) #14
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 1 month ago (2016-11-04 22:05:29 UTC) #16
commit-bot: I haz the power
4 years, 1 month ago (2016-11-04 22:07:49 UTC) #18
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/ece209ef4fba37f1eb500fa61e128bac2c9a5e8f
Cr-Commit-Position: refs/heads/master@{#430026}

Powered by Google App Engine
This is Rietveld 408576698