Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1170)

Unified Diff: third_party/WebKit/Source/devtools/front_end/console/ConsoleViewMessage.js

Issue 2472183002: DevTools: Fix wrapping bugs in console (Closed)
Patch Set: fix tests, remove unnecessary consoleView class Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/devtools/front_end/console/ConsoleViewMessage.js
diff --git a/third_party/WebKit/Source/devtools/front_end/console/ConsoleViewMessage.js b/third_party/WebKit/Source/devtools/front_end/console/ConsoleViewMessage.js
index a3df7117d2d7faddee6c0afc3ba0a8e3bd2a5c07..c1c215f6bb1321a217af6b314e4df14fc26f3a74 100644
--- a/third_party/WebKit/Source/devtools/front_end/console/ConsoleViewMessage.js
+++ b/third_party/WebKit/Source/devtools/front_end/console/ConsoleViewMessage.js
@@ -120,7 +120,7 @@ WebInspector.ConsoleViewMessage = class {
_buildTableMessage(consoleMessage) {
var formattedMessage = createElement('span');
WebInspector.appendStyle(formattedMessage, 'components/objectValue.css');
- formattedMessage.className = 'console-message-text source-code';
+ formattedMessage.className = 'source-code';
var anchorElement = this._buildMessageAnchor(consoleMessage);
if (anchorElement)
formattedMessage.appendChild(anchorElement);
@@ -174,7 +174,7 @@ WebInspector.ConsoleViewMessage = class {
if (flatValues.length) {
this._dataGrid = WebInspector.SortableDataGrid.create(columnNames, flatValues);
- var formattedResult = createElement('span');
+ var formattedResult = createElementWithClass('span', 'console-message-text');
var tableElement = formattedResult.createChild('div', 'console-message-formatted-table');
var dataGridContainer = tableElement.createChild('span');
tableElement.appendChild(this._formatParameter(table, true, false));
@@ -227,7 +227,7 @@ WebInspector.ConsoleViewMessage = class {
messageElement = createElement('span');
if (consoleMessage.level === WebInspector.ConsoleMessage.MessageLevel.Error ||
consoleMessage.level === WebInspector.ConsoleMessage.MessageLevel.RevokedError) {
- messageElement.createTextChildren(consoleMessage.request.requestMethod, ' ');
+ messageElement.createTextChild(consoleMessage.request.requestMethod + ' ');
messageElement.appendChild(WebInspector.Linkifier.linkifyUsingRevealer(
consoleMessage.request, consoleMessage.request.url, consoleMessage.request.url));
if (consoleMessage.request.failed)
@@ -247,10 +247,11 @@ WebInspector.ConsoleViewMessage = class {
var args = consoleMessage.parameters || [consoleMessage.messageText];
messageElement = this._format(args);
}
+ messageElement.classList.add('console-message-text');
var formattedMessage = createElement('span');
WebInspector.appendStyle(formattedMessage, 'components/objectValue.css');
- formattedMessage.className = 'console-message-text source-code';
+ formattedMessage.className = 'source-code';
var anchorElement = this._buildMessageAnchor(consoleMessage);
if (anchorElement)
@@ -304,7 +305,6 @@ WebInspector.ConsoleViewMessage = class {
*/
_buildMessageWithStackTrace(consoleMessage, target, linkifier) {
var toggleElement = createElementWithClass('div', 'console-message-stack-trace-toggle');
- var triangleElement = toggleElement.createChild('div', 'console-message-stack-trace-triangle');
var contentElement = toggleElement.createChild('div', 'console-message-stack-trace-wrapper');
var messageElement = this._buildMessage(consoleMessage);
@@ -335,7 +335,6 @@ WebInspector.ConsoleViewMessage = class {
}
clickableElement.addEventListener('click', toggleStackTrace, false);
- triangleElement.addEventListener('click', toggleStackTrace, false);
if (consoleMessage.type === WebInspector.ConsoleMessage.MessageType.Trace)
expandStackTrace(true);

Powered by Google App Engine
This is Rietveld 408576698