Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Unified Diff: tools/android/customtabs_benchmark/java/src/org/chromium/customtabs/test/MainActivity.java

Issue 2472163003: [CustomTabs] Report the navigation start as absolute time (Closed)
Patch Set: Compute time offset Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/android/customtabs_benchmark/java/src/org/chromium/customtabs/test/MainActivity.java
diff --git a/tools/android/customtabs_benchmark/java/src/org/chromium/customtabs/test/MainActivity.java b/tools/android/customtabs_benchmark/java/src/org/chromium/customtabs/test/MainActivity.java
index 22006cd9c00ce4181352bafe529514e30ed3a36a..6fcb9cbda7f56bb42c27f846177356559ea17de0 100644
--- a/tools/android/customtabs_benchmark/java/src/org/chromium/customtabs/test/MainActivity.java
+++ b/tools/android/customtabs_benchmark/java/src/org/chromium/customtabs/test/MainActivity.java
@@ -96,17 +96,17 @@ public class MainActivity extends Activity {
}
public void recordIntentHasBeenSent() {
- mIntentSentMs = SystemClock.elapsedRealtime();
+ mIntentSentMs = SystemClock.uptimeMillis();
}
@Override
public void onNavigationEvent(int navigationEvent, Bundle extras) {
switch (navigationEvent) {
case CustomTabsCallback.NAVIGATION_STARTED:
- mPageLoadStartedMs = SystemClock.elapsedRealtime();
+ mPageLoadStartedMs = SystemClock.uptimeMillis();
break;
case CustomTabsCallback.NAVIGATION_FINISHED:
- mPageLoadFinishedMs = SystemClock.elapsedRealtime();
+ mPageLoadFinishedMs = SystemClock.uptimeMillis();
if (mIntentSentMs != 0 && mPageLoadStartedMs != 0) {
if (mFirstContentfulPaintMs != -1) {
logMetrics();
@@ -129,9 +129,13 @@ public class MainActivity extends Activity {
@Override
public void extraCallback(String callbackName, Bundle args) {
assert "NavigationMetrics".equals(callbackName);
- long value = args.getLong("firstContentfulPaint", -1);
+ long firstPaintMs = args.getLong("firstContentfulPaint", -1);
+ long navigationStartMs = args.getLong("navigationStart", -1);
+ if (firstPaintMs == -1 || navigationStartMs == -1) return;
// Can be reported several times, only record the first one.
- if (mFirstContentfulPaintMs == -1) mFirstContentfulPaintMs = value;
+ if (mFirstContentfulPaintMs == -1) {
+ mFirstContentfulPaintMs = navigationStartMs + firstPaintMs;
+ }
if (!mAlreadyLogged && mPageLoadFinishedMs != 0) logMetrics();
}

Powered by Google App Engine
This is Rietveld 408576698