Chromium Code Reviews| Index: chrome/browser/page_load_metrics/observers/android_page_load_metrics_observer.cc |
| diff --git a/chrome/browser/page_load_metrics/observers/android_page_load_metrics_observer.cc b/chrome/browser/page_load_metrics/observers/android_page_load_metrics_observer.cc |
| index 7dcc94a5071c73c7982440f866e333050d7488af..bd445805d7003d6cc2e5c0d8ff751b33600d6c0f 100644 |
| --- a/chrome/browser/page_load_metrics/observers/android_page_load_metrics_observer.cc |
| +++ b/chrome/browser/page_load_metrics/observers/android_page_load_metrics_observer.cc |
| @@ -9,6 +9,7 @@ |
| #include "base/android/jni_android.h" |
| #include "base/android/jni_string.h" |
| #include "base/android/scoped_java_ref.h" |
| +#include "base/time/time.h" |
| #include "chrome/browser/page_load_metrics/page_load_metrics_util.h" |
| #include "content/public/browser/browser_thread.h" |
| #include "content/public/browser/web_contents.h" |
| @@ -19,6 +20,17 @@ AndroidPageLoadMetricsObserver::AndroidPageLoadMetricsObserver( |
| content::WebContents* web_contents) |
| : web_contents_(web_contents) {} |
| +page_load_metrics::PageLoadMetricsObserver::ObservePolicy |
| +AndroidPageLoadMetricsObserver::OnStart( |
| + content::NavigationHandle* navigation_handle, |
| + const GURL& currently_committed_url, |
| + bool started_in_foreground) { |
| + if (!navigation_handle) |
|
Bryan McQuade
2016/11/17 13:35:38
this should never happen. are you encountering cas
droger
2016/11/18 10:23:21
No, this never happened to me, I just put it there
|
| + return STOP_OBSERVING; |
| + navigation_start_ = navigation_handle->NavigationStart(); |
| + return CONTINUE_OBSERVING; |
| +} |
| + |
| void AndroidPageLoadMetricsObserver::OnFirstContentfulPaint( |
| const page_load_metrics::PageLoadTiming& timing, |
| const page_load_metrics::PageLoadExtraInfo& extra_info) { |
| @@ -29,5 +41,7 @@ void AndroidPageLoadMetricsObserver::OnFirstContentfulPaint( |
| web_contents_->GetJavaWebContents(); |
| JNIEnv* env = base::android::AttachCurrentThread(); |
| Java_PageLoadMetrics_onFirstContentfulPaint( |
| - env, java_web_contents, static_cast<jlong>(first_contentful_paint_ms)); |
| + env, java_web_contents, |
| + static_cast<jlong>(navigation_start_.ToInternalValue()), |
| + static_cast<jlong>(first_contentful_paint_ms)); |
| } |