[DevTools]: Expose V8 version in /json/version

chromecast/browser/devtools/remote_debugging_server.cc

Index: chromecast/browser/devtools/remote_debugging_server.cc
diff --git a/chromecast/browser/devtools/remote_debugging_server.cc b/chromecast/browser/devtools/remote_debugging_server.cc
index bf2681dce06107a7f978b33cc3b84fdd13208172..e225f65149c7680bcd3fa213b9acc4eecfa8c27d 100644
--- a/chromecast/browser/devtools/remote_debugging_server.cc
+++ b/chromecast/browser/devtools/remote_debugging_server.cc
@@ -163,7 +163,8 @@ void RemoteDebuggingServer::OnEnabledChanged() {
         base::FilePath(),
         base::FilePath(),
         std::string(),
-        GetUserAgent());
+        GetUserAgent(),
+        std::string());

[halliwell, 2016/11/17 23:22:25]

Why aren't you passing the actual v8 version here like chrome does?  What is the
implication?

[eostroukhov, 2016/11/18 00:02:23]

Linter rules prevent me from including v8.h here, and I am not sure this change
dragging this value through a significant number of files.

This value is for tools frontends to make assumptions about the V8 version, that
is tied to inspector protocol version.

     LOG(INFO) << "Devtools started: port=" << port_;
   } else if (!enabled && is_started_) {
     LOG(INFO) << "Stop devtools: port=" << port_;