[DevTools]: Expose V8 version in /json/version

chromecast/browser/devtools/remote_debugging_server.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chromecast/browser/devtools/remote_debugging_server.h"
 
 #include "base/bind.h"
 #include "base/bind_helpers.h"
 #include "base/command_line.h"
 #include "base/files/file_path.h"
@@ skipping 145 matching lines @@
 
 void RemoteDebuggingServer::OnEnabledChanged() {
   bool enabled = *pref_enabled_ && port_ != 0;
   if (enabled && !is_started_) {
     content::DevToolsAgentHost::StartRemoteDebuggingServer(
         CreateSocketFactory(port_),
         GetFrontendUrl(),
         base::FilePath(),
         base::FilePath(),
         std::string(),
-        GetUserAgent());
+        GetUserAgent(),
+        std::string());

[halliwell, 2016/11/17 23:22:25]

Why aren't you passing the actual v8 version here like chrome does?  What is the
implication?

[eostroukhov, 2016/11/18 00:02:23]

Linter rules prevent me from including v8.h here, and I am not sure this change
dragging this value through a significant number of files.

This value is for tools frontends to make assumptions about the V8 version, that
is tied to inspector protocol version.

     LOG(INFO) << "Devtools started: port=" << port_;
   } else if (!enabled && is_started_) {
     LOG(INFO) << "Stop devtools: port=" << port_;
     is_started_ = false;
     content::DevToolsAgentHost::StopRemoteDebuggingServer();
   }
 }
 
 }  // namespace shell
 }  // namespace chromecast