Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(856)

Unified Diff: content/browser/devtools/devtools_manager.cc

Issue 2472093003: [DevTools]: Expose V8 version in /json/version (Closed)
Patch Set: Android browser added Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/devtools/devtools_manager.cc
diff --git a/content/browser/devtools/devtools_manager.cc b/content/browser/devtools/devtools_manager.cc
index efd7bd71af292f85f485cba1ed27ea2244e1af34..aeaedce8160aad01d2428ec107c47b2678cd58ec 100644
--- a/content/browser/devtools/devtools_manager.cc
+++ b/content/browser/devtools/devtools_manager.cc
@@ -23,14 +23,15 @@ void DevToolsAgentHost::StartRemoteDebuggingServer(
const base::FilePath& active_port_output_directory,
const base::FilePath& debug_frontend_dir,
const std::string& product_name,
- const std::string& user_agent) {
+ const std::string& user_agent,
+ const std::string& v8_version) {
DevToolsManager* manager = DevToolsManager::GetInstance();
if (!manager->delegate())
return;
manager->SetHttpHandler(base::WrapUnique(new DevToolsHttpHandler(
manager->delegate(), std::move(server_socket_factory), frontend_url,
active_port_output_directory, debug_frontend_dir, product_name,
- user_agent)));
+ user_agent, v8_version)));
}
// static
« no previous file with comments | « content/browser/devtools/devtools_http_handler_unittest.cc ('k') | content/public/browser/devtools_agent_host.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698