Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1087)

Unified Diff: content/browser/devtools/devtools_http_handler_unittest.cc

Issue 2472093003: [DevTools]: Expose V8 version in /json/version (Closed)
Patch Set: Android browser added Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/browser/devtools/devtools_http_handler.cc ('k') | content/browser/devtools/devtools_manager.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/devtools/devtools_http_handler_unittest.cc
diff --git a/content/browser/devtools/devtools_http_handler_unittest.cc b/content/browser/devtools/devtools_http_handler_unittest.cc
index db400720f253a1ff1a51d462cabb4e14e3dcd33b..681178da0138ff1c33cb811ba73c26f8e32363d8 100644
--- a/content/browser/devtools/devtools_http_handler_unittest.cc
+++ b/content/browser/devtools/devtools_http_handler_unittest.cc
@@ -137,7 +137,7 @@ TEST_F(DevToolsHttpHandlerTest, TestStartStop) {
run_loop_2.QuitClosure()));
DevToolsAgentHost::StartRemoteDebuggingServer(
std::move(factory), std::string(), base::FilePath(), base::FilePath(),
- std::string(), std::string());
+ std::string(), std::string(), std::string());
// Our dummy socket factory will post a quit message once the server will
// become ready.
run_loop.Run();
@@ -153,7 +153,7 @@ TEST_F(DevToolsHttpHandlerTest, TestServerSocketFailed) {
run_loop_2.QuitClosure()));
DevToolsAgentHost::StartRemoteDebuggingServer(
std::move(factory), std::string(), base::FilePath(), base::FilePath(),
- std::string(), std::string());
+ std::string(), std::string(), std::string());
// Our dummy socket factory will post a quit message once the server will
// become ready.
run_loop.Run();
@@ -177,7 +177,7 @@ TEST_F(DevToolsHttpHandlerTest, TestDevToolsActivePort) {
DevToolsAgentHost::StartRemoteDebuggingServer(
std::move(factory), std::string(), temp_dir.GetPath(), base::FilePath(),
- std::string(), std::string());
+ std::string(), std::string(), std::string());
// Our dummy socket factory will post a quit message once the server will
// become ready.
run_loop.Run();
« no previous file with comments | « content/browser/devtools/devtools_http_handler.cc ('k') | content/browser/devtools/devtools_manager.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698