Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(74)

Unified Diff: content/browser/devtools/devtools_http_handler.cc

Issue 2472093003: [DevTools]: Expose V8 version in /json/version (Closed)
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/browser/devtools/devtools_http_handler.h ('k') | content/browser/devtools/devtools_manager.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/devtools/devtools_http_handler.cc
diff --git a/content/browser/devtools/devtools_http_handler.cc b/content/browser/devtools/devtools_http_handler.cc
index 98841ec8cec7ab59e58aec0d2f723fe106b7bea6..7381593e5aa78a13171873c50a3cc9ead7a1e4e3 100644
--- a/content/browser/devtools/devtools_http_handler.cc
+++ b/content/browser/devtools/devtools_http_handler.cc
@@ -524,6 +524,7 @@ void DevToolsHttpHandler::OnJsonRequest(
version.SetString("WebKit-Version", GetWebKitVersion());
version.SetString("Browser", product_name_);
version.SetString("User-Agent", user_agent_);
+ version.SetString("Js-Engine-Version", js_engine_version_);
dgozman 2016/11/04 00:25:20 Let's call it V8-Version. It's no worse than WebKi
eostroukhov 2016/11/04 00:41:02 Done.
#if defined(OS_ANDROID)
version.SetString("Android-Package",
base::android::BuildInfo::GetInstance()->package_name());
@@ -704,11 +705,13 @@ DevToolsHttpHandler::DevToolsHttpHandler(
const base::FilePath& output_directory,
const base::FilePath& debug_frontend_dir,
const std::string& product_name,
- const std::string& user_agent)
+ const std::string& user_agent,
+ const std::string& js_engine_version)
: thread_(nullptr),
frontend_url_(frontend_url),
product_name_(product_name),
user_agent_(user_agent),
+ js_engine_version_(js_engine_version),
server_wrapper_(nullptr),
delegate_(delegate),
socket_factory_(nullptr),
« no previous file with comments | « content/browser/devtools/devtools_http_handler.h ('k') | content/browser/devtools/devtools_manager.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698