Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1357)

Unified Diff: content/browser/devtools/devtools_http_handler.h

Issue 2472093003: [DevTools]: Expose V8 version in /json/version (Closed)
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/devtools/devtools_http_handler.h
diff --git a/content/browser/devtools/devtools_http_handler.h b/content/browser/devtools/devtools_http_handler.h
index 207b2a90e1208f48937f11a1dc6a0fb982ea0404..b79407dc7cb81be04751a3de69c4454c5247aa78 100644
--- a/content/browser/devtools/devtools_http_handler.h
+++ b/content/browser/devtools/devtools_http_handler.h
@@ -60,7 +60,8 @@ class DevToolsHttpHandler {
const base::FilePath& active_port_output_directory,
const base::FilePath& debug_frontend_dir,
const std::string& product_name,
- const std::string& user_agent);
+ const std::string& user_agent,
+ const std::string& js_engine_version);
~DevToolsHttpHandler();
private:
@@ -118,6 +119,7 @@ class DevToolsHttpHandler {
std::string frontend_url_;
std::string product_name_;
std::string user_agent_;
+ std::string js_engine_version_;
ServerWrapper* server_wrapper_;
std::unique_ptr<net::IPEndPoint> server_ip_address_;
using ConnectionToClientMap =

Powered by Google App Engine
This is Rietveld 408576698