Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(422)

Issue 2472073002: V8: Switch some port builders to swarming (Closed)

Created:
4 years, 1 month ago by Michael Achenbach
Modified:
4 years, 1 month ago
CC:
chromium-reviews, infra-reviews+build_chromium.org, kjellander-cc_chromium.org
Target Ref:
refs/heads/master
Project:
build
Visibility:
Public.

Description

V8: Switch some port builders to swarming Also use trusty for testing on swarming. This prepares merging a few bots on the same builders for their trusty upgrade. The bots for PPC and S390 get typical fyi-bot prio and timeouts. BUG=661956 Committed: https://chromium.googlesource.com/chromium/tools/build/+/ae0ffce9fd96b6025b7cd868e3f8b34350345e9e

Patch Set 1 #

Total comments: 3

Patch Set 2 : Review #

Messages

Total messages: 14 (8 generated)
Michael Achenbach
PTAL https://codereview.chromium.org/2472073002/diff/1/scripts/slave/recipe_modules/v8/builders.py File scripts/slave/recipe_modules/v8/builders.py (right): https://codereview.chromium.org/2472073002/diff/1/scripts/slave/recipe_modules/v8/builders.py#newcode1562 scripts/slave/recipe_modules/v8/builders.py:1562: 'swarming_dimensions': { As soon as trusty is the ...
4 years, 1 month ago (2016-11-03 11:34:44 UTC) #6
kjellander_chromium
lgtm with comment https://codereview.chromium.org/2472073002/diff/1/scripts/slave/recipe_modules/v8/builders.py File scripts/slave/recipe_modules/v8/builders.py (right): https://codereview.chromium.org/2472073002/diff/1/scripts/slave/recipe_modules/v8/builders.py#newcode1582 scripts/slave/recipe_modules/v8/builders.py:1582: 'default_expiration': 2 * 60 * 60, ...
4 years, 1 month ago (2016-11-03 12:57:32 UTC) #7
tandrii(chromium)
lgtm
4 years, 1 month ago (2016-11-03 12:59:07 UTC) #8
Michael Achenbach
https://codereview.chromium.org/2472073002/diff/1/scripts/slave/recipe_modules/v8/builders.py File scripts/slave/recipe_modules/v8/builders.py (right): https://codereview.chromium.org/2472073002/diff/1/scripts/slave/recipe_modules/v8/builders.py#newcode1582 scripts/slave/recipe_modules/v8/builders.py:1582: 'default_expiration': 2 * 60 * 60, On 2016/11/03 12:57:32, ...
4 years, 1 month ago (2016-11-03 13:09:45 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2472073002/20001
4 years, 1 month ago (2016-11-03 13:10:44 UTC) #12
commit-bot: I haz the power
4 years, 1 month ago (2016-11-03 13:20:05 UTC) #14
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/tools/build/+/ae0ffce9fd96b6025b7c...

Powered by Google App Engine
This is Rietveld 408576698