V8: Switch some port builders to swarming

scripts/slave/recipe_modules/v8/builders.py

 # Copyright 2014 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 # Contains the bulk of the V8 builder configurations so they can be reused
 # from multiple recipes.
 
 from recipe_engine.types import freeze
 from testing import V8NoExhaustiveVariants, V8Variant, V8VariantNeutral
 
@@ skipping 1512 matching lines @@
       },
       'V8 Linux - mipsel - sim - builder': {
         'chromium_apply_config': [
           'default_compiler', 'v8_ninja', 'goma', 'simulate_mipsel', 'mb'],
         'v8_config_kwargs': {
           'BUILD_CONFIG': 'Release',
           'TARGET_BITS': 32,
         },
         'bot_type': 'builder',
         'build_gs_archive': 'mipsel_sim_rel_archive',
+        'enable_swarming': True,
         'testing': {'platform': 'linux'},
         'triggers': [
           'V8 Linux - mipsel - sim',
         ],
       },
       'V8 Linux - mips64el - sim - builder': {
         'chromium_apply_config': [
           'default_compiler', 'v8_ninja', 'goma', 'simulate_mipsel', 'mb'],
         'v8_config_kwargs': {
           'BUILD_CONFIG': 'Release',
           'TARGET_BITS': 64,
         },
         'bot_type': 'builder',
         'build_gs_archive': 'mips64el_sim_rel_archive',
         'testing': {'platform': 'linux'},
       },
       'V8 Linux - mipsel - sim': {
         'chromium_apply_config': ['simulate_mipsel'],
         'v8_config_kwargs': {
           'BUILD_CONFIG': 'Release',
           'TARGET_BITS': 32,
         },
         'bot_type': 'tester',
         'parent_buildername': 'V8 Linux - mipsel - sim - builder',
         'build_gs_archive': 'mipsel_sim_rel_archive',
-        'tests': [V8Testing, Test262, SimdJs],
+        'enable_swarming': True,
+        'tests': [V8Testing_2, Test262, SimdJs],
         'testing': {'platform': 'linux'},
+        'swarming_dimensions': {

[Michael Achenbach, 2016/11/03 11:34:44]

As soon as trusty is the default, I'll remove all these extra configs again and
just change the default.

+          'os': 'Ubuntu-14.04',
+        },
       },
 ####### Category: PPC
       'V8 Linux - ppc - sim': {
         'chromium_apply_config': [
           'default_compiler', 'v8_ninja', 'goma', 'simulate_ppc', 'mb'],
         'v8_config_kwargs': {
           'BUILD_CONFIG': 'Release',
           'TARGET_BITS': 32,
         },
         'bot_type': 'builder_tester',
-        'tests': [V8Testing],
+        'enable_swarming': True,
+        'tests': [V8Testing_2],
         'testing': {'platform': 'linux'},
+        'swarming_dimensions': {
+          'os': 'Ubuntu-14.04',
+        },
+        'swarming_properties': {
+          'default_expiration': 2 * 60 * 60,

[kjellander_chromium, 2016/11/03 12:57:32]

It looks like you could extract these into constants.

[Michael Achenbach, 2016/11/03 13:09:45]

Done for some of them. There are more in this file with small differences. Will
do that in a future refactoring.

+          'default_hard_timeout': 60 * 60,
+          'default_priority': 35,
+        },
       },
       'V8 Linux - ppc64 - sim': {
         'chromium_apply_config': [
           'default_compiler', 'v8_ninja', 'goma', 'simulate_ppc', 'mb'],
         'v8_config_kwargs': {
           'BUILD_CONFIG': 'Release',
           'TARGET_BITS': 64,
         },
         'bot_type': 'builder_tester',
-        'tests': [V8Testing],
+        'enable_swarming': True,
+        'tests': [V8Testing_2],
         'testing': {'platform': 'linux'},
+        'swarming_dimensions': {
+          'os': 'Ubuntu-14.04',
+        },
+        'swarming_properties': {
+          'default_expiration': 2 * 60 * 60,
+          'default_hard_timeout': 60 * 60,
+          'default_priority': 35,
+        },
       },
 ####### Category: S390
       'V8 Linux - s390 - sim': {
         'chromium_apply_config': [
           'default_compiler', 'v8_ninja', 'goma', 'simulate_s390', 'mb'],
         'v8_config_kwargs': {
           'BUILD_CONFIG': 'Release',
           'TARGET_BITS': 32,
         },
         'bot_type': 'builder_tester',
-        'tests': [V8Testing],
+        'enable_swarming': True,
+        'tests': [V8Testing_2],
         'testing': {'platform': 'linux'},
+        'swarming_dimensions': {
+          'os': 'Ubuntu-14.04',
+        },
+        'swarming_properties': {
+          'default_expiration': 2 * 60 * 60,
+          'default_hard_timeout': 60 * 60,
+          'default_priority': 35,
+        },
       },
       'V8 Linux - s390x - sim': {
         'chromium_apply_config': [
           'default_compiler', 'v8_ninja', 'goma', 'simulate_s390', 'mb'],
         'v8_config_kwargs': {
           'BUILD_CONFIG': 'Release',
           'TARGET_BITS': 64,
         },
         'bot_type': 'builder_tester',
-        'tests': [V8Testing],
+        'enable_swarming': True,
+        'tests': [V8Testing_2],
         'testing': {'platform': 'linux'},
+        'swarming_dimensions': {
+          'os': 'Ubuntu-14.04',
+        },
+        'swarming_properties': {
+          'default_expiration': 2 * 60 * 60,
+          'default_hard_timeout': 60 * 60,
+          'default_priority': 35,
+        },
       },
 ####### Category: X87
       'V8 Linux - x87 - nosnap - debug builder': {
         'v8_apply_config': ['no_snapshot'],
         'chromium_apply_config': [
           'v8_ninja', 'default_compiler', 'goma', 'no_snapshot',  'x87', 'mb'],
         'v8_config_kwargs': {
           'BUILD_CONFIG': 'Debug',
           'TARGET_BITS': 32,
         },
@@ skipping 1160 matching lines @@
 win['chromium_apply_config'].extend(['msvs2013'])
 
 BUILDERS = freeze(BUILDERS)
 BRANCH_BUILDERS = freeze(BRANCH_BUILDERS)
 
 def iter_builders():
   for mastername, master_config in BUILDERS.iteritems():
     builders = master_config['builders']
     for buildername, bot_config in builders.iteritems():
       yield mastername, builders, buildername, bot_config