Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(109)

Issue 2471843004: Revert of Re-enable AppBannerManagerBrowserTest.WebAppBannerCreatedIndirectMultipleLargerTotal. (Closed)

Created:
4 years, 1 month ago by jam
Modified:
4 years, 1 month ago
CC:
chromium-reviews, dominickn+watch_chromium.org, pkotwicz+watch_chromium.org, zpeng+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Re-enable AppBannerManagerBrowserTest.WebAppBannerCreatedIndirectMultipleLargerTotal. (patchset #1 id:1 of https://codereview.chromium.org/2465163003/ ) Reason for revert: This is causing a lot of try bot flakes Please don't renable without fixing. See http://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyVQsSBUZsYWtlIkpBcHBCYW5uZXJNYW5hZ2VyQnJvd3NlclRlc3QuV2ViQXBwQmFubmVyQ3JlYXRlZEluZGlyZWN0TXVsdGlwbGVMYXJnZXJUb3RhbAw Original issue's description: > Re-enable AppBannerManagerBrowserTest.WebAppBannerCreatedIndirectMultipleLargerTotal. > > The failures don't reproduce locally - re-enabling to see if that > sticks. > > BUG=660798 > TBR=benwells@chromium.org > > Committed: https://crrev.com/59a0f926eee47b951754598ac77dda4a5bbafcde > Cr-Commit-Position: refs/heads/master@{#429191} TBR=benwells@chromium.org,dominickn@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=660798 Committed: https://crrev.com/e0169db530967046e639b3746dabb68741c893b8 Cr-Commit-Position: refs/heads/master@{#429585}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -2 lines) Patch
M chrome/browser/banners/app_banner_manager_browsertest.cc View 1 chunk +10 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
jam
Created Revert of Re-enable AppBannerManagerBrowserTest.WebAppBannerCreatedIndirectMultipleLargerTotal.
4 years, 1 month ago (2016-11-03 14:29:28 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2471843004/1
4 years, 1 month ago (2016-11-03 14:29:43 UTC) #3
commit-bot: I haz the power
Failed to apply the patch. On branch working_branch Your branch is up-to-date with 'origin/refs/pending/heads/master'. nothing ...
4 years, 1 month ago (2016-11-03 15:03:10 UTC) #5
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/e0169db530967046e639b3746dabb68741c893b8 Cr-Commit-Position: refs/heads/master@{#429585}
4 years, 1 month ago (2016-11-03 15:03:59 UTC) #7
Lei Zhang
4 years, 1 month ago (2016-11-03 15:26:08 UTC) #9
Message was sent while issue was closed.
lgtm x2

Powered by Google App Engine
This is Rietveld 408576698