Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(275)

Unified Diff: chrome/browser/banners/app_banner_manager_browsertest.cc

Issue 2471843004: Revert of Re-enable AppBannerManagerBrowserTest.WebAppBannerCreatedIndirectMultipleLargerTotal. (Closed)
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/banners/app_banner_manager_browsertest.cc
diff --git a/chrome/browser/banners/app_banner_manager_browsertest.cc b/chrome/browser/banners/app_banner_manager_browsertest.cc
index 1cd312703051dc08fa3418eb3aae8b696584567f..aba2708f4870760315a34951e244c3e18712af4a 100644
--- a/chrome/browser/banners/app_banner_manager_browsertest.cc
+++ b/chrome/browser/banners/app_banner_manager_browsertest.cc
@@ -256,8 +256,16 @@
SHOWING_WEB_APP_BANNER, true);
}
-IN_PROC_BROWSER_TEST_F(AppBannerManagerBrowserTest,
- WebAppBannerCreatedIndirectMultipleLargerTotal) {
+// Disabled. See http://crbug.com/660798
+#if defined(OS_LINUX) || defined(OS_MACOSX) || defined(OS_WIN)
+#define MAYBE_WebAppBannerCreatedIndirectMultipleLargerTotal \
+ DISABLED_WebAppBannerCreatedIndirectMultipleLargerTotal
+#else
+#define MAYBE_WebAppBannerCreatedIndirectMultipleLargerTotal \
+ WebAppBannerCreatedIndirectMultipleLargerTotal
+#endif
+IN_PROC_BROWSER_TEST_F(AppBannerManagerBrowserTest,
+ MAYBE_WebAppBannerCreatedIndirectMultipleLargerTotal) {
AppBannerSettingsHelper::SetEngagementWeights(1, 0.5);
AppBannerSettingsHelper::SetTotalEngagementToTrigger(4);
RunBannerTest("/banners/manifest_test_page.html", ui::PAGE_TRANSITION_LINK, 7,
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698