[DevTools] migrate InspectorCSSAgent to new style

[DevTools] migrate InspectorCSSAgent to new style

BUG=none
R=dgozman@chromium.org

Committed: https://crrev.com/a8b605106b36ad73ed37fe3a7bded7f631ac014c
Cr-Commit-Position: refs/heads/master@{#429513}

[kozy, 2016-11-02 16:52:23]

Dmitry, please take a look!

[dgozman, 2016-11-02 17:44:29]

https://codereview.chromium.org/2471823002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/inspector/InspectorCSSAgent.cpp (left):

https://codereview.chromium.org/2471823002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/inspector/InspectorCSSAgent.cpp:2275: if
(!element || element->getPseudoId())
getPseudoId check is lost

https://codereview.chromium.org/2471823002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/inspector/InspectorCSSAgent.cpp (right):

https://codereview.chromium.org/2471823002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/inspector/InspectorCSSAgent.cpp:301: Response
toResponse(ExceptionState& exceptionState) {
Use InspectorDOMAgent::toResponse instead.

https://codereview.chromium.org/2471823002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/inspector/InspectorCSSAgent.cpp:918: if
(!element) {
remove {}

https://codereview.chromium.org/2471823002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/inspector/InspectorCSSAgent.cpp:925: if
(!ownerDocument->isActive()) {
remove {}

https://codereview.chromium.org/2471823002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/inspector/InspectorCSSAgent.cpp:1224: return
Response::Error("No style sheet with given id found");
assertStyleSheetForId?

https://codereview.chromium.org/2471823002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/inspector/InspectorCSSAgent.cpp:1417:
toResponse(exceptionState).errorMessage().utf8().data()));
Can we just add two strings instead of using expensive utf8().data() ?

https://codereview.chromium.org/2471823002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/inspector/InspectorCSSAgent.cpp:2141: if
(!sourceData) {
remove {}

https://codereview.chromium.org/2471823002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/inspector/InspectorCSSAgent.h (right):

https://codereview.chromium.org/2471823002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/inspector/InspectorCSSAgent.h:254: Response
elementForId(int nodeId, Element*&);
Ain't this the same as InspectorDOMAgent::assertElement ?

[kozy, 2016-11-02 18:56:47]

All done, please take a look!

https://codereview.chromium.org/2471823002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/inspector/InspectorCSSAgent.cpp (left):

https://codereview.chromium.org/2471823002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/inspector/InspectorCSSAgent.cpp:2275: if
(!element || element->getPseudoId())
On 2016/11/02 17:44:28, dgozman wrote:
> getPseudoId check is lost

Done.

https://codereview.chromium.org/2471823002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/inspector/InspectorCSSAgent.cpp (right):

https://codereview.chromium.org/2471823002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/inspector/InspectorCSSAgent.cpp:301: Response
toResponse(ExceptionState& exceptionState) {
On 2016/11/02 17:44:28, dgozman wrote:
> Use InspectorDOMAgent::toResponse instead.

Done.

https://codereview.chromium.org/2471823002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/inspector/InspectorCSSAgent.cpp:918: if
(!element) {
On 2016/11/02 17:44:28, dgozman wrote:
> remove {}

Done.

https://codereview.chromium.org/2471823002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/inspector/InspectorCSSAgent.cpp:925: if
(!ownerDocument->isActive()) {
On 2016/11/02 17:44:29, dgozman wrote:
> remove {}

Done.

https://codereview.chromium.org/2471823002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/inspector/InspectorCSSAgent.cpp:1224: return
Response::Error("No style sheet with given id found");
On 2016/11/02 17:44:28, dgozman wrote:
> assertStyleSheetForId?

Done.

https://codereview.chromium.org/2471823002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/inspector/InspectorCSSAgent.cpp:1417:
toResponse(exceptionState).errorMessage().utf8().data()));
On 2016/11/02 17:44:28, dgozman wrote:
> Can we just add two strings instead of using expensive utf8().data() ?

Done.

https://codereview.chromium.org/2471823002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/inspector/InspectorCSSAgent.cpp:2141: if
(!sourceData) {
On 2016/11/02 17:44:29, dgozman wrote:
> remove {}

Done.

https://codereview.chromium.org/2471823002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/inspector/InspectorCSSAgent.h (right):

https://codereview.chromium.org/2471823002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/inspector/InspectorCSSAgent.h:254: Response
elementForId(int nodeId, Element*&);
On 2016/11/02 17:44:29, dgozman wrote:
> Ain't this the same as InspectorDOMAgent::assertElement ?

Done.

[dgozman, 2016-11-02 19:49:15]

lgtm

[kozy, 2016-11-03 00:02:24]

The CQ bit was checked by kozyatinskiy@chromium.org

[commit-bot: I haz the power, 2016-11-03 00:02:59]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-03 02:10:07]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-11-03 02:11:32]

Description was changed from

==========
[DevTools] migrate InspectorCSSAgent to new style

BUG=none
R=dgozman@chromium.org
==========

to

==========
[DevTools] migrate InspectorCSSAgent to new style

BUG=none
R=dgozman@chromium.org

Committed: https://crrev.com/a8b605106b36ad73ed37fe3a7bded7f631ac014c
Cr-Commit-Position: refs/heads/master@{#429513}
==========

[commit-bot: I haz the power, 2016-11-03 02:11:33]

Patchset 2 (id:??) landed as
https://crrev.com/a8b605106b36ad73ed37fe3a7bded7f631ac014c
Cr-Commit-Position: refs/heads/master@{#429513}