Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(72)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2471733003: Update or remove any remaining references to viewvc/blink. (Closed)

Created:
4 years, 1 month ago by Dirk Pranke
Modified:
4 years, 1 month ago
Reviewers:
jam, jbroman, Steven Holte
CC:
Aaron Boodman, abarth-chromium, asvitkine+watch_chromium.org, blink-reviews, chromium-reviews, darin (slow to review), darin-cc_chromium.org, Dirk Pranke, feature-media-reviews_chromium.org, jam, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Update or remove any remaining references to viewvc/blink. R=jam@chromium.org, jbroman@chromium.org BUG=617246 Committed: https://crrev.com/041e8a4a76af92da0d78a4225bc4a14c6c03a412 Cr-Commit-Position: refs/heads/master@{#429438}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -21 lines) Patch
M content/common/page_state_serialization.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M media/tools/layout_tests/layouttest_analyzer.py View 2 chunks +2 lines, -2 lines 0 comments Download
M media/tools/layout_tests/layouttest_analyzer_helpers.py View 1 chunk +0 lines, -1 line 0 comments Download
M media/tools/layout_tests/layouttests.py View 1 chunk +2 lines, -5 lines 0 comments Download
M mojo/public/tools/bindings/pylib/mojom/generate/template_expander.py View 1 chunk +1 line, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/history/reload-during-load-after-load-event.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/history/reload-during-load-after-load-event-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/misc/form-base-target-blank-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/misc/resources/form-base-target-blank.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/paint/invalidation/non-text-link-invalidation-optimization.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitruby/PrettyPatch/PrettyPatch.rb View 1 chunk +1 line, -1 line 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 18 (9 generated)
Dirk Pranke
4 years, 1 month ago (2016-11-02 02:47:01 UTC) #1
jbroman
lgtm
4 years, 1 month ago (2016-11-02 14:25:25 UTC) #6
jam
lgtm
4 years, 1 month ago (2016-11-02 21:53:38 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2471733003/1
4 years, 1 month ago (2016-11-02 22:29:58 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/295381)
4 years, 1 month ago (2016-11-02 22:40:24 UTC) #11
Steven Holte
histograms lgtm
4 years, 1 month ago (2016-11-02 22:49:06 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2471733003/1
4 years, 1 month ago (2016-11-02 22:51:12 UTC) #15
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-02 22:56:51 UTC) #16
commit-bot: I haz the power
4 years, 1 month ago (2016-11-02 22:59:58 UTC) #18
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/041e8a4a76af92da0d78a4225bc4a14c6c03a412
Cr-Commit-Position: refs/heads/master@{#429438}

Powered by Google App Engine
This is Rietveld 408576698