Side by Side Diff
Use n/p to move between diff chunks; N/P to move between comments.
Draft comments are only viewable by you.
Keyboard Shortcuts
File
u
:
up to issue
j
/
k
:
jump to file after / before current file
J
/
K
:
jump to next file with a comment after / before current file
Side-by-side diff
i
:
toggle intra-line diffs
e
:
expand all comments
c
:
collapse all comments
s
:
toggle showing all comments
n
/
p
:
next / previous diff chunk or comment
N
/
P
:
next / previous comment
<Up>
/
<Down>
:
next / previous line
Issue
u
:
up to list of issues
j
/
k
:
jump to patch after / before current patch
o
/
<Enter>
:
open current patch in side-by-side view
i
:
open current patch in unified diff view
Issue List
j
/
k
:
jump to issue after / before current issue
o
/
<Enter>
:
open current issue
Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr)
|
Please choose your nickname with
Settings
|
Help
|
Chromium Project
|
Gerrit Changes
|
Sign out
(12)
Issues
Search
My Issues
|
Starred
Open
|
Closed
|
All
Side by Side Diff: third_party/WebKit/LayoutTests/http/tests/misc/form-base-target-blank-expected.txt
Issue
2471733003
:
Update or remove any remaining references to viewvc/blink. (Closed)
Patch Set:
Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments.
Draft comments are only viewable by you.
Context:
3 lines
10 lines
25 lines
50 lines
75 lines
100 lines
Whole file
Column Width:
Tab Spaces:
Jump to:
content/common/page_state_serialization.cc
media/tools/layout_tests/layouttest_analyzer.py
media/tools/layout_tests/layouttest_analyzer_helpers.py
media/tools/layout_tests/layouttests.py
mojo/public/tools/bindings/pylib/mojom/generate/template_expander.py
third_party/WebKit/LayoutTests/http/tests/history/reload-during-load-after-load-event.html
third_party/WebKit/LayoutTests/http/tests/history/reload-during-load-after-load-event-expected.txt
third_party/WebKit/LayoutTests/http/tests/misc/form-base-target-blank-expected.txt
third_party/WebKit/LayoutTests/http/tests/misc/resources/form-base-target-blank.html
third_party/WebKit/LayoutTests/paint/invalidation/non-text-link-invalidation-optimization.html
third_party/WebKit/Tools/Scripts/webkitruby/PrettyPatch/PrettyPatch.rb
tools/metrics/histograms/histograms.xml
View unified diff
|
Download patch
« no previous file with comments
|
« third_party/WebKit/LayoutTests/http/tests/history/reload-during-load-after-load-event-expected.txt
('k') |
third_party/WebKit/LayoutTests/http/tests/misc/resources/form-base-target-blank.html »
('j') |
no next file with comments »
Toggle Intra-line Diffs
('i') |
Expand Comments
('e') |
Collapse Comments
('c') |
Show Comments
Hide Comments
('s')
OLD
NEW
1 Test that if a form is submitted from a document with a base element that sets a target,
1 Test that if a form is submitted from a document with a base element that sets a target,
2 the form's target attribute takes precedence over the base's target attribute.
2 the form's target attribute takes precedence over the base's target attribute.
3
This was regressed in http://src.chromium.org/viewvc/blink/?view=revision&revisi
on=153933
3
This was regressed in https://chromium.googlesource.com/chromium/src/+/653893343
54b996ae8490706d84d5848f5f023e7
4 This test will timeout if it fails.
4 This test will timeout if it fails.
5
5
OLD
NEW
« no previous file with comments
|
« third_party/WebKit/LayoutTests/http/tests/history/reload-during-load-after-load-event-expected.txt
('k') |
third_party/WebKit/LayoutTests/http/tests/misc/resources/form-base-target-blank.html »
('j') |
no next file with comments »
Issue 2471733003: Update or remove any remaining references to viewvc/blink. (Closed)
Created 4 years, 1 month ago by Dirk Pranke
Modified 4 years, 1 month ago
Reviewers: jbroman, jam, Steven Holte
Base URL:
Comments: 0
This is Rietveld
408576698