third_party/WebKit/Source/bindings/tests/results/core/TestPermissiveDictionary.h - Issue 2471393004: bindings: Use forward declarations for wrapper types in dictionary_impl

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/tests/results/core/TestPermissiveDictionary.h

Issue 2471393004: bindings: Use forward declarations for wrapper types in dictionary_impl (Closed)

Patch Set: WIP Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/bindings/tests/idls/core/TestDictionary.idl ('K') | « third_party/WebKit/Source/bindings/tests/results/core/TestInterfaceEventInit.cpp ('k') | third_party/WebKit/Source/bindings/tests/results/core/TestPermissiveDictionary.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/bindings/tests/results/core/TestPermissiveDictionary.h

diff --git a/third_party/WebKit/Source/bindings/tests/results/core/TestPermissiveDictionary.h b/third_party/WebKit/Source/bindings/tests/results/core/TestPermissiveDictionary.h

index cc9d80ffd3f8e565ce063308d7fa4008a3654584..845511ae46cc8b310db1466b7ec6312c49bf83dc 100644

--- a/third_party/WebKit/Source/bindings/tests/results/core/TestPermissiveDictionary.h

+++ b/third_party/WebKit/Source/bindings/tests/results/core/TestPermissiveDictionary.h

@@ -22,9 +22,9 @@ class CORE_EXPORT TestPermissiveDictionary : public IDLDictionaryBase {

TestPermissiveDictionary();

virtual ~TestPermissiveDictionary();

- bool hasBooleanMember() const { return !m_booleanMember.isNull(); }

- bool booleanMember() const { return m_booleanMember.get(); }

- void setBooleanMember(bool value) { m_booleanMember = value; }

+ bool hasBooleanMember() const;

+ bool booleanMember() const;

+ void setBooleanMember(bool);

v8::Local<v8::Value> toV8Impl(v8::Local<v8::Object>, v8::Isolate*) const override;

DECLARE_VIRTUAL_TRACE();